Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In Adapter class, check for record_separate_redirects from vcr and modify request #111

Open
sckott opened this issue Feb 25, 2021 · 2 comments
Open

In Adapter class, check for record_separate_redirects from vcr and modify request #111

sckott opened this issue Feb 25, 2021 · 2 comments
Milestone
v2.2

Comments

@sckott
Copy link
Collaborator

sckott commented Feb 25, 2021

related to #110 and via ropensci/vcr#220
@sckott sckott added this to the v0.8 milestone Feb 25, 2021
sckott added a commit that referenced this issue Feb 25, 2021
@sckott
#111 new helper fxn handle_separate_redirects used in Adapter class
8f7b437 
- check if record_separate_redirects=TRUE
- if TRUE, set followlocation=0L (dont follow redirects) both in the curl options and in the curl handle
sckott added a commit that referenced this issue Feb 25, 2021
@sckott
#111 fix to handle_separate_redirects() fxn - only set handle opt fol…
e518fa1 
…lowlocation if in crul
sckott added a commit that referenced this issue Mar 2, 2021
@sckott
#111 more work on handling redirects - a few new helper fxns, not wor…
408bb73 
…king yet
@sckott sckott modified the milestones: v0.8, v0.9 Mar 12, 2021
@sckott sckott modified the milestones: v0.9, v1.0 Dec 9, 2021
@sckott sckott modified the milestones: v1.0, v1.2 Oct 15, 2023
@sckott
Copy link
Collaborator Author

sckott commented Nov 16, 2024

may be close to done, but going to hold off til next milestone

@sckott sckott modified the milestones: v1.2, v1.4 Nov 16, 2024
@sckott
Copy link
Collaborator Author

sckott commented Feb 9, 2025

Work is now on branch redirects, see diff to main main...redirects

Right now removing hanging code for redirects work on main

sckott added a commit that referenced this issue Feb 9, 2025
@sckott
remove redirects code incorrectly hanging around ounused on main branch
47a0c65 
#111
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.2
Development

No branches or pull requests
1 participant
@sckott