-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
option in get_csid() to return named vector rather than list #191
Milestone
Comments
Once fixed, the example in the README should get updated too. |
Oh, hmm.. I didn't realize compounds can have multiple csid's. Maybe an alternate solution is to have an optional |
Aariq
changed the title
get_csid() should return named vector rather than list
option in get_csid() to return named vector rather than list
Jan 8, 2020
I think that's fine. We might want to fix the README though. Right now
there is code in the ChemSpider section that is commented out because it
was throwing errors.
…On Thu, Jan 23, 2020 at 4:48 PM Tamás Stirling ***@***.***> wrote:
@Aariq <https://github.com/Aariq> do you agree that we can postone this
issue for v0.6.0?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#191?email_source=notifications&email_token=AGB2K34DY27G2ABAOCNQXLDQ7IGBHA5CNFSM4KEOWSX2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJY7B6I#issuecomment-577892601>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGB2K33TX6L3GMNASFPRIULQ7IGBHANCNFSM4KEOWSXQ>
.
|
4 tasks
I'm closing this for now because the README is fixed and we haven't settled on a consistent output for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Other cs_*() functions take vectors of IDs, so the current implementation of
get_csid()
doesn't play nice with them when looking for results for more than one compound.The text was updated successfully, but these errors were encountered: