Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viewing maps #76

Open
micha-silver opened this issue Dec 15, 2022 · 1 comment
Open

Viewing maps #76

micha-silver opened this issue Dec 15, 2022 · 1 comment

Comments

@micha-silver
Copy link
Contributor

Currently we use two different packages for displaying maps: leaflet and tmap. The leaflet package is used in 7 functions, and tmap in only two. In an effort to reduce package dependencies, we should focus on only one of these.

Last year I added tmap since I needed to display raster images (i.e. in the get_site_ODS() function), and leaflet is a bit troublesome and tricky with raster data. However now there is a new function in terra (which we need installed anyway) called plet (yes, that's the spelling 😃 ) which displays a terra::SpatRaster with leaflet. This function requires leaflet >= 2.1.1. That minimum version is already specified in the DESCRIPTION file.

So I suggest to change the functions that currently use tmap over to leaflet. And remove the dependency on tmap.

@micha-silver
Copy link
Contributor Author

One problem: the minimum requirement to use leaflet with the plet() function is greater than 2.1.1. i.e. leaflet > 2.1.1. That means installing from github, not CRAN. Can we do that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant