You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently we use two different packages for displaying maps: leaflet and tmap. The leaflet package is used in 7 functions, and tmap in only two. In an effort to reduce package dependencies, we should focus on only one of these.
Last year I added tmap since I needed to display raster images (i.e. in the get_site_ODS() function), and leaflet is a bit troublesome and tricky with raster data. However now there is a new function in terra (which we need installed anyway) called plet (yes, that's the spelling 😃 ) which displays a terra::SpatRaster with leaflet. This function requires leaflet >= 2.1.1. That minimum version is already specified in the DESCRIPTION file.
So I suggest to change the functions that currently use tmap over to leaflet. And remove the dependency on tmap.
The text was updated successfully, but these errors were encountered:
One problem: the minimum requirement to use leaflet with the plet() function is greater than 2.1.1. i.e. leaflet > 2.1.1. That means installing from github, not CRAN. Can we do that?
Currently we use two different packages for displaying maps:
leaflet
andtmap
. Theleaflet
package is used in 7 functions, andtmap
in only two. In an effort to reduce package dependencies, we should focus on only one of these.Last year I added
tmap
since I needed to display raster images (i.e. in theget_site_ODS()
function), andleaflet
is a bit troublesome and tricky with raster data. However now there is a new function interra
(which we need installed anyway) calledplet
(yes, that's the spelling 😃 ) which displays a terra::SpatRaster withleaflet
. This function requiresleaflet >= 2.1.1
. That minimum version is already specified in the DESCRIPTION file.So I suggest to change the functions that currently use
tmap
over toleaflet
. And remove the dependency ontmap
.The text was updated successfully, but these errors were encountered: