Skip to content

Commit 1e9f6da

Browse files
authored
Merge pull request #206 from ropensci/silence-s3-warnings
Silences warnings about undeclared/unknown classes in method defs
2 parents 0e40dec + 7803922 commit 1e9f6da

4 files changed

Lines changed: 12 additions & 4 deletions

File tree

DESCRIPTION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,7 @@ Collate:
5252
'add_characters.R'
5353
'add_meta.R'
5454
'add_namespaces.R'
55+
'nexmlTree.R'
5556
'add_trees.R'
5657
'character_classes.R'
5758
'concatenate_nexml.R'
@@ -71,7 +72,6 @@ Collate:
7172
'internal_name_by_id.R'
7273
'internal_nexml_id.R'
7374
'meta.R'
74-
'nexmlTree.R'
7575
'nexml_add.R'
7676
'nexml_get.R'
7777
'nexml_methods.R'

R/add_trees.R

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
#' @include nexmlTree.R
2+
NULL
3+
14
#' add_trees
25
#'
36
#' add_trees

R/get_trees.R

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
#' @include nexmlTree.R
2+
NULL
3+
14
#' extract all phylogenetic trees in ape format
25
#'
36
#' extract all phylogenetic trees in ape format

R/nexmlTree.R

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,11 @@ setClass("phyloS4",
44
tip.label = "character",
55
edge.length = "numeric"))
66
setOldClass("phylo", S4Class="phyloS4")
7-
# FIXME repeat selectMethod for all ape, geiger, etc methods(??)
8-
selectMethod("show", "phylo")
9-
removeClass("phyloS4")
7+
8+
## multiPhylo and multiPhyloList are used in other files, but perhaps it is
9+
## best to keep the definitions all here
10+
setOldClass("multiPhylo")
11+
setOldClass("multiPhyloList")
1012

1113
setClass("nexmlTree", slots = c(nexml = "nexml"), contains="phylo")
1214
setMethod("show", "nexmlTree", function(object) print.phylo(object))

0 commit comments

Comments
 (0)