[build] Use appropriate CMake to link against MacOS framework

The previous logic to link against MacOS frameworks was just passing the string "-framework <NAME>". This bypasses the CMake find_library logic, in particular it disregards CMake variables such as CMAKE_OSX_SYSROOT, CMAKE_FIND_ROOT_PATH, CMAKE_FRAMEWORK_PATH etc. Switch to the standard find_library function to find the framework and then use the result as a library target, thus benefiting from this logic described in the CMake documentation:

```
If the library found is a framework, then <VAR> will be set to the full path to the framework <fullPath>/A.framework. When a full path to a framework is used as a library, CMake will use a -framework A, and a -F<fullPath> to link the framework to the target.
```

Author: vepadulano

core/macosx/CMakeLists.txt

@@ -12,16 +12,18 @@ if(NOT APPLE)
   return()
 endif()
 
+find_library(CORESYMBOLICATION_FRAMEWORK CoreSymbolication PATHS "${CMAKE_OSX_SYSROOT}/System/Library/PrivateFrameworks" REQUIRED)
 target_link_libraries(Core PRIVATE
-  "-F/System/Library/PrivateFrameworks -framework CoreSymbolication"
+  ${CORESYMBOLICATION_FRAMEWORK}
 )
 
 if(cocoa)
   set_property(TARGET Core APPEND PROPERTY DICT_HEADERS TMacOSXSystem.h)
 
   target_include_directories(Core PRIVATE inc)
 
-  target_link_libraries(Core PRIVATE "-framework Cocoa")
+  find_library(COCOA_FRAMEWORK Cocoa REQUIRED)
+  target_link_libraries(Core PRIVATE ${COCOA_FRAMEWORK})
 
   ROOT_OBJECT_LIBRARY(Macosx
     src/CocoaUtils.mm

graf2d/cocoa/CMakeLists.txt

@@ -9,6 +9,9 @@
 # @author Pere Mato, CERN
 ############################################################################
 
+find_library(COCOA_FRAMEWORK Cocoa REQUIRED)
+find_library(OPENGL_FRAMEWORK OpenGL REQUIRED)
+
 ROOT_STANDARD_LIBRARY_PACKAGE(GCocoa
   HEADERS
     TGCocoa.h
@@ -36,8 +39,8 @@ ROOT_STANDARD_LIBRARY_PACKAGE(GCocoa
     Gui
   LIBRARIES
     GQuartz
-    "-framework Cocoa"
-    "-framework OpenGL"
+    ${COCOA_FRAMEWORK}
+    ${OPENGL_FRAMEWORK}
     ${FREETYPE_LIBRARIES}
 )
 

graf2d/quartz/CMakeLists.txt

@@ -11,6 +11,8 @@
 
 add_definitions("-ObjC++")
 
+find_library(COCOA_FRAMEWORK Cocoa REQUIRED)
+
 # Dictionary not needed.
 ROOT_LINKER_LIBRARY(GQuartz
     src/QuartzFillArea.mm
@@ -19,7 +21,7 @@ ROOT_LINKER_LIBRARY(GQuartz
     src/QuartzText.mm
     src/QuartzUtils.mm
   LIBRARIES
-    "-framework Cocoa"
+    ${COCOA_FRAMEWORK}
   DEPENDENCIES
     Core
     MathCore

gui/cefdisplay/CMakeLists.txt

@@ -23,7 +23,8 @@ if(ROOT_ARCHITECTURE MATCHES macosx)
    set(CEF_platform src/gui_handler_mac.mm)
    set(CEF_RELEASE_DIR ${CEF_root}/Release/Chromium\ Embedded\ Framework.framework)
    set(CEF_LIBRARY ${CEF_RELEASE_DIR}/Chromium\ Embedded\ Framework)
-   set(CEF_LIB_DEPENDENCY "-framework Foundation")
+   find_library(FOUNDATION_FRAMEWORK Foundation REQUIRED)
+   set(CEF_LIB_DEPENDENCY ${FOUNDATION_FRAMEWORK})
    set(CEF_DLL_WRAPPER ${CEF_root}/build/libcef_dll_wrapper/libcef_dll_wrapper.a)
    file(MAKE_DIRECTORY ${CMAKE_BINARY_DIR}/Frameworks/Chromium\ Embedded\ Framework.framework)
    file(COPY ${CEF_RELEASE_DIR} DESTINATION ${CMAKE_BINARY_DIR}/Frameworks/)