Skip to content

Commit 2804128

Browse files
ferdymercuryhageboeck
authored andcommitted
[skip-ci] fix some doxygen warnings about undocumented params
1 parent 93ac579 commit 2804128

File tree

17 files changed

+39
-29
lines changed

17 files changed

+39
-29
lines changed

core/base/src/TVirtualPad.cxx

+1
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ TVirtualPad::TContext::TContext(Bool_t _interactive)
4141

4242
////////////////////////////////////////////////////////////////////////////////
4343
/// Constructor which stores gPad and set it to new value
44+
/// @param gpad pointer to current pad
4445
/// @param interactive defines how gPad will be restored: with cd() call (kTRUE) or just by assign gPad back
4546
/// @param not_null allows to set only pad which is not null
4647

core/metacling/src/TCling.cxx

+1
Original file line numberDiff line numberDiff line change
@@ -1335,6 +1335,7 @@ static void RegisterPreIncludedHeaders(cling::Interpreter &clingInterp)
13351335
/// \param title title for TInterpreter
13361336
/// \param argv - array of arguments passed to the cling::Interpreter constructor
13371337
/// e.g. `-DFOO=bar`. The last element of the array must be `nullptr`.
1338+
/// \param interpLibHandle handle to interpreter library
13381339

13391340
TCling::TCling(const char *name, const char *title, const char* const argv[], void *interpLibHandle)
13401341
: TInterpreter(name, title), fGlobalsListSerial(-1), fMapfile(nullptr),

gui/webdisplay/src/RWebWindow.cxx

+5-4
Original file line numberDiff line numberDiff line change
@@ -519,11 +519,12 @@ unsigned RWebWindow::AddDisplayHandle(bool headless_mode, const std::string &key
519519

520520
//////////////////////////////////////////////////////////////////////////////////////////
521521
/// Check if provided hash, ntry parameters from the connection request could be accepted
522-
/// \param hash - provided hash value which should match with HMAC hash for generated before connection key
523-
/// \param ntry - connection attempt number provided together with request, must come in increasing order
524-
/// \param remote - boolean flag indicating if request comming from remote (via real http),
522+
/// \param conn shared pointer to the web connection
523+
/// \param hash provided hash value which should match with HMAC hash for generated before connection key
524+
/// \param ntry connection attempt number provided together with request, must come in increasing order
525+
/// \param remote boolean flag indicating if request comming from remote (via real http),
525526
/// for local displays like Qt5 or CEF simpler connection rules are applied
526-
/// \param test_first_time - true if hash/ntry tested for the first time, false appears only with
527+
/// \param test_first_time true if hash/ntry tested for the first time, false appears only with
527528
/// websocket when connection accepted by server
528529

529530
bool RWebWindow::_CanTrustIn(std::shared_ptr<WebConn> &conn, const std::string &hash, const std::string &ntry, bool remote, bool test_first_time)

net/http/src/TRootSniffer.cxx

+2
Original file line numberDiff line numberDiff line change
@@ -1509,6 +1509,7 @@ Bool_t TRootSniffer::CallProduceImage(const std::string &/*kind*/, const std::st
15091509
/// * "exe.txt" - method execution with debug output
15101510
/// * "cmd.json" - execution of registered commands
15111511
///
1512+
/// @param options specific options
15121513
/// @param res returns result - binary or text.
15131514

15141515
Bool_t TRootSniffer::Produce(const std::string &path, const std::string &file, const std::string &options, std::string &res)
@@ -1629,6 +1630,7 @@ TFolder *TRootSniffer::GetSubFolder(const char *subfolder, Bool_t force)
16291630
////////////////////////////////////////////////////////////////////////////////
16301631
/// Register object in subfolder structure
16311632
///
1633+
/// @param obj pointer to TObject
16321634
/// @param subfolder can have many levels like:
16331635
///
16341636
/// TRootSniffer* sniff = new TRootSniffer("sniff");

net/httpsniff/src/TRootSnifferFull.cxx

+3-1
Original file line numberDiff line numberDiff line change
@@ -529,9 +529,11 @@ Bool_t TRootSnifferFull::ProduceXml(const std::string &path, const std::string &
529529
////////////////////////////////////////////////////////////////////////////////
530530
/// Execute command for specified object
531531
///
532-
/// options include method and extra list of parameters
532+
/// @param path the object path
533+
/// @param options include method and extra list of parameters
533534
/// sniffer should be not-readonly to allow execution of the commands
534535
/// @param reskind defines kind of result 0 - debug, 1 - json, 2 - binary
536+
/// @param res_str result string
535537

536538
Bool_t TRootSnifferFull::ProduceExe(const std::string &path, const std::string &options, Int_t reskind, std::string &res_str)
537539
{

roofit/batchcompute/src/CudaInterface.h

+3-3
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ void copyDeviceToDeviceImpl(const void *src, void *dest, std::size_t n, CudaStre
8585
*
8686
* @param[in] src Pointer to the source memory on the host.
8787
* @param[in] dest Pointer to the destination memory on the device.
88-
* @param[in] nBytes Number of bytes to copy.
88+
* @param[in] n Number of bytes to copy.
8989
* @param[in] stream CudaStream for asynchronous memory transfer (optional).
9090
*/
9191
template <class T>
@@ -99,7 +99,7 @@ void copyHostToDevice(const T *src, T *dest, std::size_t n, CudaStream * = nullp
9999
*
100100
* @param[in] src Pointer to the source memory on the device.
101101
* @param[in] dest Pointer to the destination memory on the host.
102-
* @param[in] nBytes Number of bytes to copy.
102+
* @param[in] n Number of bytes to copy.
103103
* @param[in] stream CudaStream for asynchronous memory transfer (optional).
104104
*/
105105
template <class T>
@@ -113,7 +113,7 @@ void copyDeviceToHost(const T *src, T *dest, std::size_t n, CudaStream * = nullp
113113
*
114114
* @param[in] src Pointer to the source memory on the device.
115115
* @param[in] dest Pointer to the destination memory on the device.
116-
* @param[in] nBytes Number of bytes to copy.
116+
* @param[in] n Number of bytes to copy.
117117
* @param[in] stream CudaStream for asynchronous memory transfer (optional).
118118
*/
119119
template <class T>

roofit/histfactory/src/HistFactoryImpl.cxx

+6-6
Original file line numberDiff line numberDiff line change
@@ -34,12 +34,12 @@ namespace Detail {
3434
* ranges for the gamma parameter and provides a reasonable starting point for
3535
* pre-fit errors.
3636
*
37-
* @param gammas The gamma parameters to be configured.
38-
* @param sigmaRel The relative sigma values to be used for configuring the
39-
* limits and errors.
40-
* @param minSigma The minimum relative sigma threshold. If a relative sigma is
41-
* below this threshold, the gamma parameter is set to be
42-
* constant.
37+
* @param gammas The gamma parameters to be configured.
38+
* @param relSigmas The relative sigma values to be used for configuring the
39+
* limits and errors.
40+
* @param minSigma The minimum relative sigma threshold. If a relative sigma is
41+
* below this threshold, the gamma parameter is set to be
42+
* constant.
4343
*/
4444
void configureConstrainedGammas(RooArgList const &gammas, std::span<const double> relSigmas, double minSigma)
4545
{

roofit/histfactory/src/ParamHistFunc.cxx

+3-4
Original file line numberDiff line numberDiff line change
@@ -556,10 +556,9 @@ double ParamHistFunc::evaluate() const
556556
}
557557

558558
////////////////////////////////////////////////////////////////////////////////
559-
/// Find all bins corresponding to the values of the observables in `evalData`, and evaluate
560-
/// the associated parameters.
561-
/// \param[in,out] evalData Input/output data for evaluating the ParamHistFunc.
562-
/// \param[in] normSet Normalisation set passed on to objects that are serving values to us.
559+
/// Find all bins corresponding to the values of the observables in `ctx`,
560+
// and evaluate the associated parameters.
561+
/// \param[in,out] ctx Input/output data for evaluating the ParamHistFunc.
563562
void ParamHistFunc::doEval(RooFit::EvalContext & ctx) const
564563
{
565564
std::span<double> output = ctx.output();

roofit/histfactory/src/PiecewiseInterpolation.cxx

+1-2
Original file line numberDiff line numberDiff line change
@@ -204,8 +204,7 @@ inline double broadcast(std::span<const double> const &s, std::size_t i)
204204

205205
////////////////////////////////////////////////////////////////////////////////
206206
/// Interpolate between input distributions for all values of the observable in `evalData`.
207-
/// \param[in,out] evalData Struct holding spans pointing to input data. The results of this function will be stored here.
208-
/// \param[in] normSet Arguments to normalise over.
207+
/// \param[in,out] ctx Struct holding spans pointing to input data. The results of this function will be stored here.
209208
void PiecewiseInterpolation::doEval(RooFit::EvalContext &ctx) const
210209
{
211210
std::span<double> sum = ctx.output();

roofit/roofitcore/src/RooAbsPdf.cxx

+1-1
Original file line numberDiff line numberDiff line change
@@ -683,7 +683,7 @@ void RooAbsPdf::getLogProbabilities(std::span<const double> pdfValues, double *
683683
/// \param[in] sumEntries The number of observed events.
684684
/// \param[in] nset The normalization set when asking the pdf for the expected
685685
/// number of events.
686-
/// \param[in] observedSumW2 The number of observed events when weighting with
686+
/// \param[in] sumEntriesW2 The number of observed events when weighting with
687687
/// squared weights. If non-zero, the weight-squared error
688688
/// correction is applied to the extended term.
689689
/// \param[in] doOffset Offset the extended term by a counterterm where the

roofit/roofitcore/src/RooBinSamplingPdf.cxx

+1-2
Original file line numberDiff line numberDiff line change
@@ -158,8 +158,7 @@ double RooBinSamplingPdf::evaluate() const {
158158

159159
////////////////////////////////////////////////////////////////////////////////
160160
/// Integrate the PDF over all its bins, and return a batch with those values.
161-
/// \param[in,out] evalData Struct with evaluation data.
162-
/// \param[in] normSet Normalisation set that's used to evaluate the PDF.
161+
/// \param[in,out] ctx Struct with evaluation data
163162
void RooBinSamplingPdf::doEval(RooFit::EvalContext &ctx) const
164163
{
165164
std::span<double> output = ctx.output();

roofit/roofitcore/src/RooPolyFunc.cxx

+2
Original file line numberDiff line numberDiff line change
@@ -223,6 +223,8 @@ void fixObservables(const RooAbsCollection &observables)
223223
//////////////////////////////////////////////////////////////////////////////
224224
/// Taylor expanding given function in terms of observables around
225225
/// observableValues. Supports expansions upto order 2.
226+
/// \param[in] name the name
227+
/// \param[in] title the title
226228
/// \param[in] func Function of variables that is taylor expanded.
227229
/// \param[in] observables Set of variables to perform the expansion.
228230
/// It's type is RooArgList to ensure that it is always ordered the

tmva/pymva/src/PyMethodBase.cxx

+2-1
Original file line numberDiff line numberDiff line change
@@ -404,7 +404,8 @@ std::vector<size_t> PyMethodBase::GetDataFromList(PyObject* listObject){
404404
/// dictionary object and returns the associated value or throws runtime
405405
/// error.
406406
///
407-
/// \param[in] listObject Python Dict object
407+
/// \param[in] dict Python Dict object
408+
/// \param[in] key the key to search for in the dict
408409
/// \return Associated value PyObject
409410
PyObject *PyMethodBase::GetValueFromDict(PyObject *dict, const char *key)
410411
{

tmva/pymva/src/RModelParser_Keras.cxx

+1
Original file line numberDiff line numberDiff line change
@@ -763,6 +763,7 @@ std::unique_ptr<ROperator> MakeKerasIdentity(PyObject* fLayer)
763763

764764
//////////////////////////////////////////////////////////////////////////////////
765765
/// \param[in] filename file location of Keras .h5
766+
/// \param[in] batch_size if not given, 1 is used if the model does not provide it
766767
/// \return Parsed RModel object
767768
///
768769
/// The `Parse()` function defined in `TMVA::Experimental::SOFIE::PyKeras` will

tree/dataframe/inc/ROOT/RDF/RLoopManager.hxx

+2
Original file line numberDiff line numberDiff line change
@@ -308,6 +308,7 @@ public:
308308
/// \param[in] datasetName Name of the TChain
309309
/// \param[in] fileNameGlob File name (or glob) in which the TChain is stored.
310310
/// \param[in] defaultColumns List of default columns, see
311+
/// \param[in] checkFile file validator boolean
311312
/// \ref https://root.cern/doc/master/classROOT_1_1RDataFrame.html#default-branches "Default column lists"
312313
/// \return the RLoopManager instance.
313314
std::shared_ptr<ROOT::Detail::RDF::RLoopManager>
@@ -318,6 +319,7 @@ CreateLMFromTTree(std::string_view datasetName, std::string_view fileNameGlob,
318319
/// \param[in] datasetName Name of the TChain
319320
/// \param[in] fileNameGlobs List of file names (potentially globs).
320321
/// \param[in] defaultColumns List of default columns, see
322+
/// \param[in] checkFile file validator boolean
321323
/// \ref https://root.cern/doc/master/classROOT_1_1RDataFrame.html#default-branches "Default column lists"
322324
/// \return the RLoopManager instance.
323325
std::shared_ptr<ROOT::Detail::RDF::RLoopManager>

tree/dataframe/src/RDataFrame.cxx

+3-3
Original file line numberDiff line numberDiff line change
@@ -1804,7 +1804,7 @@ RDataFrame::RDataFrame(std::string_view treeName, TDirectory *dirPtr, const Colu
18041804
////////////////////////////////////////////////////////////////////////////
18051805
/// \brief Build the dataframe.
18061806
/// \param[in] treeName Name of the tree contained in the directory
1807-
/// \param[in] filenameglob TDirectory where the tree is stored, e.g. a TFile.
1807+
/// \param[in] fileNameGlob TDirectory where the tree is stored, e.g. a TFile.
18081808
/// \param[in] defaultColumns Collection of default columns.
18091809
///
18101810
/// The filename glob supports the same type of expressions as TChain::Add(), and it is passed as-is to TChain's
@@ -1827,8 +1827,8 @@ RDataFrame::RDataFrame(std::string_view treeName, std::string_view fileNameGlob,
18271827

18281828
////////////////////////////////////////////////////////////////////////////
18291829
/// \brief Build the dataframe.
1830-
/// \param[in] treeName Name of the tree contained in the directory
1831-
/// \param[in] fileglobs Collection of file names of filename globs
1830+
/// \param[in] datasetName Name of the dataset contained in the directory
1831+
/// \param[in] fileNameGlobs Collection of file names of filename globs
18321832
/// \param[in] defaultColumns Collection of default columns.
18331833
///
18341834
/// The filename globs support the same type of expressions as TChain::Add(), and each glob is passed as-is

tree/tree/src/InternalTreeUtils.cxx

+2-2
Original file line numberDiff line numberDiff line change
@@ -417,7 +417,7 @@ std::vector<std::unique_ptr<TChain>> MakeFriends(const ROOT::TreeUtils::RFriendI
417417
////////////////////////////////////////////////////////////////////////////////
418418
/// \brief Recursively expand the glob to take care of potential wildcard
419419
/// specials for subdirectories in the glob.
420-
/// \param[in] l The list of full paths to files.
420+
/// \param[in] out The list of full paths to files.
421421
/// \param[in] glob The glob to expand.
422422
/// \throws std::runtime_error If the directory parts of the glob refer to a
423423
/// path that cannot be opened.
@@ -530,7 +530,7 @@ std::vector<std::string> ExpandGlob(const std::string &glob)
530530
////////////////////////////////////////////////////////////////////////////////
531531
/// \brief Returns the cluster boundaries and number of entries of the input tree.
532532
/// \param[in] treename Name of the tree.
533-
/// \param[in] filename Path to the file.
533+
/// \param[in] path Path to the file.
534534
/// \return a pair (cluster_boundaries, n_entries). The vector of cluster
535535
/// of cluster boundaries contains the beginning entry of the first
536536
/// cluster up to the ending entry of the last cluster, e.g. for a tree

0 commit comments

Comments
 (0)