Extension appears to leak file descriptors, can cause Shell crash

[AdamWill]

There's a Fedora bug report for a GNOME Shell crash:

https://bugzilla.redhat.com/show_bug.cgi?id=1506435

which to me looks a lot like it may be caused by this extension leaking file descriptors. Note that per the backtrace (attachment named 'backtrace') the crash is caused by 'too many open files' - "Creating pipes for GWakeup: Too many open files" - and the list of open file descriptors (attachment named open_fds) lists 1024 open file descriptors (which is the per-process limit), the majority of which are to do with desktop backgrounds.

Can you please check if there's a bug in the extension code causing it to leak file descriptors somewhere? Thanks.

[AdamWill]

Oh, forgot to mention, attachment 'var_log_messages' makes it clear the user had this extension enabled.

[AdamWill]

Reporter of https://bugzilla.redhat.com/show_bug.cgi?id=1518189 , a similar crasher, also has this extension enabled.

[rodakorn]

Hi Adam!

I will check it soon. These days I'm a little busy but I think next week I can do it. 👍

[AdamWill]

Downstream reporter confirmed the crashes go away if he disables the extension:

https://bugzilla.redhat.com/show_bug.cgi?id=1518189#c25

[audreytoskin]

The developer of another wallpapers extension filed a bug against GNOME Shell about the shell sometimes crashing when changing the wallpaper. Possibly relevant?

https://bugzilla.gnome.org/show_bug.cgi?id=786025