Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PR Template on pull request creation #992

Closed
camgrsl opened this issue Mar 10, 2025 · 8 comments
Closed

Support PR Template on pull request creation #992

camgrsl opened this issue Mar 10, 2025 · 8 comments
Assignees

Comments

@camgrsl
Copy link

camgrsl commented Mar 10, 2025

Hi there,

The only option to actually have a template in the created PR is to duplicate the PR template as a ISSUE_TEMPLATE and set copyIssueDescriptionToPR: true which actually copy the description inside a toggle.

It would be nice to see getPrBody function to support fetching the pull_request template present in the repository

What do you think?

@robvanderleek
Copy link
Owner

Hi @camgrsl 👋

Thanks for the feature suggestion.

Just to be clear: are you suggesting adding a new option (for example copyPullRequestTemplateToPR: true) and then include this template in the PR description (not within a toggle)?
Or do you expect this to be the default behavior?

There are quite some subtleties when it comes to PR templates, but I'm sure basic support can be added to CIB.

@camgrsl
Copy link
Author

camgrsl commented Mar 11, 2025

Exactly copyPullRequestTemplateToPR would be perfect.

this template in the PR description (not within a toggle)?

Definitely!

I wouldn't expect to be default behavior as it would change existing integrations.
Basic support is more than enough, Just copying the pull request template and adding the closes #ticketNumber at the end of the PR would do the job 🙏

@robvanderleek robvanderleek self-assigned this Mar 12, 2025
Copy link

Hi there 👋

You are using the free plan of the Create Issue Branch App.
Due to its popularity, offering the App for free is becoming too costly for me.
The free plan was therefore deprecated on March 1st, 2025.

If you want to continue using this App, please upgrade to the Developer plan.
The Developer plan costs only $1 per month (or $10 yearly).
You can upgrade on the GitHub Marketplace

If you have any questions reach out to me by opening an issue.

Copy link

@robvanderleek
Copy link
Owner

Hi @camgrsl

I've just released the basic support.

Let me know if this fits your use-case.

@camgrsl
Copy link
Author

camgrsl commented Mar 18, 2025

@robvanderleek thanks for quickly integrating this 🙏
After copying copyPullRequestTemplateToPR: true, it's not copying pull_request_template as expected.
Have you tested it live on github or only by mocking it locally?
I'm currently using robvanderleek/create-issue-branch@main main branch, but I can see that you forgot to add a new release as well

@robvanderleek
Copy link
Owner

Hi @camgrsl

Too bad the new feature does not work for you.
I've tested the App version live, for example, this PR contains the contents of this template.

The current implementation looks for a file called .github/pull_request_template.md

However, I did not check the action, and indeed forgot to make a new release.
I've just did the release, can you try again please?

@camgrsl
Copy link
Author

camgrsl commented Mar 19, 2025

Well, maybe something cache related. It works like a charm now!
Thanks @robvanderleek , really appreciated 🙏

@camgrsl camgrsl closed this as completed Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants