New class for return values of interface methods PART2

[randaz81]

sequel of #3051.
All navigation interfaces/devices have been updated to use yarp::dev::ReturnValue

[sonarqubecloud]

Quality Gate failed

Failed conditions
44.6% Coverage on New Code (required ≥ 80%)
7.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

[PeterBowman]

Hello, @randaz81. After the merge, I am getting build errors on Ubuntu 22.04 + Clang 14.0.0 (CI logs):

[ 33%] Building CXX object src/libYARP_dev/src/CMakeFiles/YARP_dev.dir/yarp/dev/ISpeechSynthesizer.cpp.o
In file included from /home/runner/work/tools/tools/.deps/yarp/src/libYARP_dev/src/yarp/dev/ISpeechSynthesizer.cpp:6:
In file included from /home/runner/work/tools/tools/.deps/yarp/src/libYARP_dev/src/yarp/dev/ISpeechSynthesizer.h:11:
/home/runner/work/tools/tools/.deps/yarp/src/libYARP_dev/src/yarp/dev/ReturnValue.h:76:63: error: no type named 'source_location' in namespace 'std'
inline ReturnValue YARP_METHOD_NOT_YET_IMPLEMENTED(const std::source_location& location = std::source_location::current())
                                                         ~~~~~^
/home/runner/work/tools/tools/.deps/yarp/src/libYARP_dev/src/yarp/dev/ReturnValue.h:76:96: error: no member named 'source_location' in namespace 'std'
inline ReturnValue YARP_METHOD_NOT_YET_IMPLEMENTED(const std::source_location& location = std::source_location::current())
                                                                                          ~~~~~^
/home/runner/work/tools/tools/.deps/yarp/src/libYARP_dev/src/yarp/dev/ReturnValue.h:81:54: error: no type named 'source_location' in namespace 'std'
inline ReturnValue YARP_METHOD_DEPRECATED(const std::source_location& location = std::source_location::current())
                                                ~~~~~^
/home/runner/work/tools/tools/.deps/yarp/src/libYARP_dev/src/yarp/dev/ReturnValue.h:81:87: error: no member named 'source_location' in namespace 'std'
inline ReturnValue YARP_METHOD_DEPRECATED(const std::source_location& location = std::source_location::current())
                                                                                 ~~~~~^
4 errors generated.
gmake[2]: *** [src/libYARP_dev/src/CMakeFiles/YARP_dev.dir/build.make:577: src/libYARP_dev/src/CMakeFiles/YARP_dev.dir/yarp/dev/ISpeechSynthesizer.cpp.o] Error 1
gmake[1]: *** [CMakeFiles/Makefile2:4888: src/libYARP_dev/src/CMakeFiles/YARP_dev.dir/all] Error 2
gmake: *** [Makefile:171: all] Error 2
Error: Process completed with exit code 2.

Basically: no type named 'source_location' in namespace 'std'. According to cppreference, this is a C++20 feature.

[randaz81]

Here is the issue: clang 14 is supposed to support c++20 (in fact this is checked by yarp code), but not all its features.
While we consider if this is an issue to manage (or update minimum requirements), I recommend to switch to clang 17, which is successfully tested on ubuntu 22.04 by yarp CI.

Btw, the standard gcc compiler (v11) shipped with Ubuntu 22.04 is not affected by this issue.

[PeterBowman]

Oops, YARP indeed requires C++20 at least since v3.9 (I thought it was still at C++17): 8f45be9. Upgrading compilers seems justified.

By the way, @randaz81, shouldn't target_compiler_features() be updated as well to point at cxx_std_20? See search results. Currently, C++20 is required to compile YARP, but dependent projects only need C++17 due to this.

[randaz81]

By the way, @randaz81, shouldn't target_compiler_features() be updated as well to point at cxx_std_20? See search results. Currently, C++20 is required to compile YARP, but dependent projects only need C++17 due to this.

Thank you! That piece of the code was indeed forgotten and not updated!