Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake_minimum_required is now 3.19 #3076

Merged
merged 2 commits into from
Jan 31, 2024
Merged

cmake_minimum_required is now 3.19 #3076

merged 2 commits into from
Jan 31, 2024

Conversation

randaz81
Copy link
Member

cmake_minimum_required is now 3.19

@randaz81 randaz81 added Component: CMake Type: Breaking/Behaviour Change Involves breaking user code or behaviour labels Jan 30, 2024
@randaz81 randaz81 added this to the YARP 3.10.0 milestone Jan 30, 2024
@randaz81 randaz81 self-assigned this Jan 30, 2024
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (ac33ace) 107672 58237 54.09%
Head commit (ba2f479) 107672 (+0) 58235 (-2) 54.09% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#3076) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

@randaz81 randaz81 merged commit c09c9f6 into master Jan 31, 2024
64 of 73 checks passed
@randaz81 randaz81 deleted the cmake3_19 branch January 31, 2024 11:53
@PeterBowman
Copy link
Member

@randaz81 I just noticed that the following lines (and similar) can be deleted now:

yarp/CMakeLists.txt

Lines 7 to 15 in 8d2d4a0

# UseSWIG generates now standard target names.
if(${CMAKE_VERSION} VERSION_GREATER_EQUAL 3.13)
cmake_policy(SET CMP0078 OLD)
endif()
# UseSWIG honors SWIG_MODULE_NAME via -module flag.
if(${CMAKE_VERSION} VERSION_GREATER_EQUAL 3.14)
cmake_policy(SET CMP0086 OLD)
endif()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: CMake Type: Breaking/Behaviour Change Involves breaking user code or behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants