Java and C# bindings extended analog sensor interfaces do not compile. #1770

Nicogene · 2018-06-25T16:31:25Z

Describe the bug
The java bindings doesn't compile since #1756
To Reproduce
Enable CREATE_JAVA and compiles

Output

/home/ngenesio/yarp/build/generated_src/java/yarpJAVA_wrap.cxx:43754:17: error: use of undeclared identifier 'ThreeAxisGyroscope_EXTENDED_INTERFACE_get'
  result = (int)ThreeAxisGyroscope_EXTENDED_INTERFACE_get();
                ^
/home/ngenesio/yarp/build/generated_src/java/yarpJAVA_wrap.cxx:43942:17: error: use of undeclared identifier 'ThreeAxisLinearAccelerometer_EXTENDED_INTERFACE_get'
  result = (int)ThreeAxisLinearAccelerometer_EXTENDED_INTERFACE_get();
                ^
/home/ngenesio/yarp/build/generated_src/java/yarpJAVA_wrap.cxx:44130:17: error: use of undeclared identifier 'ThreeAxisMagnetometer_EXTENDED_INTERFACE_get'
  result = (int)ThreeAxisMagnetometer_EXTENDED_INTERFACE_get();
                ^
/home/ngenesio/yarp/build/generated_src/java/yarpJAVA_wrap.cxx:44318:17: error: use of undeclared identifier 'OrientationSensor_EXTENDED_INTERFACE_get'
  result = (int)OrientationSensor_EXTENDED_INTERFACE_get();
                ^
/home/ngenesio/yarp/build/generated_src/java/yarpJAVA_wrap.cxx:44535:17: error: use of undeclared identifier 'TemperatureSensor_EXTENDED_INTERFACE_get'
  result = (int)TemperatureSensor_EXTENDED_INTERFACE_get();
                ^
/home/ngenesio/yarp/build/generated_src/java/yarpJAVA_wrap.cxx:44723:17: error: use of undeclared identifier 'SixAxisForceTorqueSensor_EXTENDED_INTERFACE_get'
  result = (int)SixAxisForceTorqueSensor_EXTENDED_INTERFACE_get();
                ^
/home/ngenesio/yarp/build/generated_src/java/yarpJAVA_wrap.cxx:44905:17: error: use of undeclared identifier 'ContactLoadCellArray_EXTENDED_INTERFACE_get'
  result = (int)ContactLoadCellArray_EXTENDED_INTERFACE_get();
                ^
/home/ngenesio/yarp/build/generated_src/java/yarpJAVA_wrap.cxx:45070:17: error: use of undeclared identifier 'EncoderArray_EXTENDED_INTERFACE_get'
  result = (int)EncoderArray_EXTENDED_INTERFACE_get();
                ^
/home/ngenesio/yarp/build/generated_src/java/yarpJAVA_wrap.cxx:45235:17: error: use of undeclared identifier 'SkinPatch_EXTENDED_INTERFACE_get'
  result = (int)SkinPatch_EXTENDED_INTERFACE_get();

Configuration (please complete the following information):

OS: Ubuntu 16.04
yarp version: latest devel
compiler: clang 3.8

The text was updated successfully, but these errors were encountered:

Nicogene · 2018-06-25T18:14:45Z

Probably I have the build messy because I just noticed that the binding of JAVA are compiled on travis and there they work. I will check tomorrow and eventually close it!

Nicogene · 2018-06-26T09:58:38Z

I can reproduce it also on a clean build, could be related to the version of swig?
On my machine I have 3.0.8-0ubuntu3

nunoguedelha · 2018-07-02T00:31:37Z

Hi @Nicogene , ...

regarding the SWIG version

as we generate bindings for Matlab too, we are actually using a SWIG fork that Silvio and I maintain: https://github.com/robotology-dependencies/swig. The default branch is matlab and the latest commit displays the Swig version 3.0.11. I strongly suggest that you get aligned with our SWIG branch.

regarding the BUG

The generated symbols you are seeing are clearly incomplete. You should get IThreeAxisLinearAccelerometers_getNrOfThreeAxisLinearAccelerometers or IThreeAxisLinearAccelerometers_getThreeAxisLinearAccelerometerStatus, etc, and not just ThreeAxisLinearAccelerometer_EXTENDED_INTERFACE_get. You might get the right symbols with the updated SWIG.
Let me know how it goes.

Nicogene · 2018-07-02T16:41:07Z

Hi @nunoguedelha !

I updated to Bionic Beaver and now I have swig 3.0.12 and the problem persists.

I don't know what could be the problem in my case 🤔

nunoguedelha · 2018-07-03T13:33:27Z

It looks like the preprocessor of SWIG is doing a wrong interpretation of the defines in the interface file .../robotology-superbuild/robotology/YARP/bindings/macrosForMultipleAnalogSensors.i.
We actually pulled an old fix on an issue with %define and #define handling by SWIG: robotology-dependencies/swig#1.

You should really try with the latest commit on the matlab branch in the repo in robotology-dependencies: https://github.com/robotology-dependencies/swig.

nunoguedelha · 2018-07-04T17:20:47Z

@Nicogene , any news?

Nicogene · 2018-07-11T12:23:02Z

Also @drdanz had my same issue and he has swig 3.0.12 too.
On travis it works because on travis there ins swig 3.0.2.

So if I understood correctly these changes (robotology-dependencies/swig#1) are necessary to compile the java bindings with newer version of swig than 3.0.2.

So this is the situation now

swig version
`3.0.2`	✅
`3.0.8`	❌
`3.0.11`	❌
`3.0.11`(`matlab` branch)	✅
`3.0.12`	❌

We have to fix it, we can't assume that the users use this custom version of swig.

traversaro · 2018-07-11T12:30:50Z

I am surprised that 3.0.12 is not working, as the related fix swig/swig#781 should be part of the released version.

drdanz · 2018-07-11T12:38:58Z

Tested clean builds with all "official" swig versions from 3.0.0 to 3.0.12:

swig version
`3.0.0`	✅
`3.0.1`	✅
`3.0.2`	✅
`3.0.3`	❌
`3.0.4`	❌
`3.0.5`	❌
`3.0.6`	❌
`3.0.7`	❌
`3.0.8`	❌
`3.0.9`	❌
`3.0.10`	❌
`3.0.11`	❌
`3.0.11` (matlab branch)	✅
`3.0.12`	❌

On travis we have 3.0.2
The matlab branch is very suspicious, just to be sure, on what system are you building the bindings with the matlab branch, and are you sure that it is not using the system share files (i.e. /usr/share/swig3.0) instead of the custom build ones?

traversaro · 2018-07-11T13:00:31Z

The matlab branch contains explicitly the fix for this issue (swig/swig#781), that was backported in robotology-dependencies/swig#1 . However, I did not test it.

drdanz · 2018-07-11T13:09:33Z

This PR is available both in 3.0.11 and 3.0.12 but none of them seem to work

nunoguedelha · 2018-07-11T13:25:44Z

I have tested the matlab branch on MacOS, and also on Linux (icub-30 machine). And I'm sure I was using the custom build swig executable. Apparently the fix was reverted from the official releases after 3.0.2.

drdanz · 2018-07-25T13:00:12Z

Since we are releasing on YARP 3.1.0 next Monday, we need to fix this ASAP.
@traversaro, @nunoguedelha what do you suggest?

Can we insert the broken part in a #if !defined(SWIGJAVA) block?

traversaro · 2018-07-25T13:01:57Z

Can we insert the broken part in a #if !defined(SWIGJAVA) block?

I guess yes.

CC-Issue: robotology#1770

nunoguedelha · 2018-07-25T13:44:58Z

Can we insert the broken part in a #if !defined(SWIGJAVA) block?

Seems fine to me too.

CC-Issue: robotology#1770

drdanz · 2018-07-26T08:43:27Z

#1817 disabled the interfaces for java, I renamed the bug, but I think we shouldn't close this until we actually fix the issue, or swig is fixed upstream...

Nicogene · 2018-07-26T08:48:07Z

I agree !

See #1770, same fix as in #1817 (which was for Java)

Tobias-Fischer · 2018-08-15T15:11:17Z

The same happens in C#:

/home/tobias/robot/yarp/build2/bindings/csharp/yarpCSHARP_wrap.cxx: In function ‘int CSharp_ThreeAxisGyroscope_EXTENDED_INTERFACE_get()’:
/home/tobias/robot/yarp/build2/bindings/csharp/yarpCSHARP_wrap.cxx:35585:59: error: ‘ThreeAxisGyroscope_EXTENDED_INTERFACE_get’ was not declared in this scope
   result = (int)ThreeAxisGyroscope_EXTENDED_INTERFACE_get();
                                                           ^
/home/tobias/robot/yarp/build2/bindings/csharp/yarpCSHARP_wrap.cxx: In function ‘int CSharp_ThreeAxisLinearAccelerometer_EXTENDED_INTERFACE_get()’:
/home/tobias/robot/yarp/build2/bindings/csharp/yarpCSHARP_wrap.cxx:35743:69: error: ‘ThreeAxisLinearAccelerometer_EXTENDED_INTERFACE_get’ was not declared in this scope
   result = (int)ThreeAxisLinearAccelerometer_EXTENDED_INTERFACE_get();
                                                                     ^
/home/tobias/robot/yarp/build2/bindings/csharp/yarpCSHARP_wrap.cxx: In function ‘int CSharp_ThreeAxisMagnetometer_EXTENDED_INTERFACE_get()’:
/home/tobias/robot/yarp/build2/bindings/csharp/yarpCSHARP_wrap.cxx:35901:62: error: ‘ThreeAxisMagnetometer_EXTENDED_INTERFACE_get’ was not declared in this scope
   result = (int)ThreeAxisMagnetometer_EXTENDED_INTERFACE_get();
                                                              ^
/home/tobias/robot/yarp/build2/bindings/csharp/yarpCSHARP_wrap.cxx: In function ‘int CSharp_OrientationSensor_EXTENDED_INTERFACE_get()’:
/home/tobias/robot/yarp/build2/bindings/csharp/yarpCSHARP_wrap.cxx:36059:58: error: ‘OrientationSensor_EXTENDED_INTERFACE_get’ was not declared in this scope
   result = (int)OrientationSensor_EXTENDED_INTERFACE_get();
                                                          ^
/home/tobias/robot/yarp/build2/bindings/csharp/yarpCSHARP_wrap.cxx: In function ‘int CSharp_TemperatureSensor_EXTENDED_INTERFACE_get()’:
/home/tobias/robot/yarp/build2/bindings/csharp/yarpCSHARP_wrap.cxx:36243:58: error: ‘TemperatureSensor_EXTENDED_INTERFACE_get’ was not declared in this scope
   result = (int)TemperatureSensor_EXTENDED_INTERFACE_get();
                                                          ^
/home/tobias/robot/yarp/build2/bindings/csharp/yarpCSHARP_wrap.cxx: In function ‘int CSharp_SixAxisForceTorqueSensor_EXTENDED_INTERFACE_get()’:
/home/tobias/robot/yarp/build2/bindings/csharp/yarpCSHARP_wrap.cxx:36401:65: error: ‘SixAxisForceTorqueSensor_EXTENDED_INTERFACE_get’ was not declared in this scope
   result = (int)SixAxisForceTorqueSensor_EXTENDED_INTERFACE_get();
                                                                 ^
/home/tobias/robot/yarp/build2/bindings/csharp/yarpCSHARP_wrap.cxx: In function ‘int CSharp_ContactLoadCellArray_EXTENDED_INTERFACE_get()’:
/home/tobias/robot/yarp/build2/bindings/csharp/yarpCSHARP_wrap.cxx:36553:61: error: ‘ContactLoadCellArray_EXTENDED_INTERFACE_get’ was not declared in this scope
   result = (int)ContactLoadCellArray_EXTENDED_INTERFACE_get();
                                                             ^
/home/tobias/robot/yarp/build2/bindings/csharp/yarpCSHARP_wrap.cxx: In function ‘int CSharp_EncoderArray_EXTENDED_INTERFACE_get()’:
/home/tobias/robot/yarp/build2/bindings/csharp/yarpCSHARP_wrap.cxx:36691:53: error: ‘EncoderArray_EXTENDED_INTERFACE_get’ was not declared in this scope
   result = (int)EncoderArray_EXTENDED_INTERFACE_get();
                                                     ^
/home/tobias/robot/yarp/build2/bindings/csharp/yarpCSHARP_wrap.cxx: In function ‘int CSharp_SkinPatch_EXTENDED_INTERFACE_get()’:
/home/tobias/robot/yarp/build2/bindings/csharp/yarpCSHARP_wrap.cxx:36829:50: error: ‘SkinPatch_EXTENDED_INTERFACE_get’ was not declared in this scope
   result = (int)SkinPatch_EXTENDED_INTERFACE_get();

I created a patch in #1830

See #1770, same fix as in #1817 (which was for Java)

randaz81 · 2025-01-21T18:47:40Z

closed because too old. This issue might be not present anymore in newer versions of yarp/swig

Nicogene added Issue Type: Bug Involves some intervention from a system administrator Component: Bindings swig, python, java, ruby, perl, octave, matlab, lua, csharp, tcl labels Jun 25, 2018

Nicogene assigned nunoguedelha Jun 25, 2018

drdanz added the Severity: Release Blocker label Jul 12, 2018

drdanz added a commit to drdanz/yarp that referenced this issue Jul 25, 2018

bindings: Disable extended analog sensor interfaces in java

c122134

CC-Issue: robotology#1770

drdanz mentioned this issue Jul 25, 2018

bindings: Disable extended analog sensor interfaces in java #1817

Merged

drdanz added a commit to drdanz/yarp that referenced this issue Jul 25, 2018

bindings: Disable extended analog sensor interfaces in java

a79661b

CC-Issue: robotology#1770

drdanz removed the Severity: Release Blocker label Jul 26, 2018

drdanz changed the title ~~Java Bindings don't compile~~ Java bindings extended analog sensor interfaces do not compile. Jul 26, 2018

drdanz added Severity: Minor labels Jul 26, 2018

Tobias-Fischer added a commit that referenced this issue Aug 15, 2018

Bindings: Disable extended analog sensor interfaces in CSharp

08dc994

See #1770, same fix as in #1817 (which was for Java)

Tobias-Fischer mentioned this issue Aug 15, 2018

Bindings: Disable extended analog sensor interfaces in CSharp #1830

Merged

traversaro changed the title ~~Java bindings extended analog sensor interfaces do not compile.~~ Java and C# bindings extended analog sensor interfaces do not compile. Aug 21, 2018

traversaro pushed a commit that referenced this issue Aug 21, 2018

Bindings: Disable extended analog sensor interfaces in CSharp

48a38fa

See #1770, same fix as in #1817 (which was for Java)

drdanz removed Severity: Minor labels Nov 12, 2021

randaz81 closed this as completed Jan 21, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Java and C# bindings extended analog sensor interfaces do not compile. #1770

Java and C# bindings extended analog sensor interfaces do not compile. #1770

Nicogene commented Jun 25, 2018 •

edited

Loading

Nicogene commented Jun 25, 2018 •

edited

Loading

Nicogene commented Jun 26, 2018

nunoguedelha commented Jul 2, 2018

Nicogene commented Jul 2, 2018

nunoguedelha commented Jul 3, 2018

nunoguedelha commented Jul 4, 2018

Nicogene commented Jul 11, 2018 •

edited

Loading

traversaro commented Jul 11, 2018

drdanz commented Jul 11, 2018

traversaro commented Jul 11, 2018 •

edited

Loading

drdanz commented Jul 11, 2018

nunoguedelha commented Jul 11, 2018 •

edited

Loading

drdanz commented Jul 25, 2018

traversaro commented Jul 25, 2018

nunoguedelha commented Jul 25, 2018

drdanz commented Jul 26, 2018

Nicogene commented Jul 26, 2018

Tobias-Fischer commented Aug 15, 2018

randaz81 commented Jan 21, 2025 •

edited

Loading

Java and C# bindings extended analog sensor interfaces do not compile. #1770

Java and C# bindings extended analog sensor interfaces do not compile. #1770

Comments

Nicogene commented Jun 25, 2018 • edited Loading

Nicogene commented Jun 25, 2018 • edited Loading

Nicogene commented Jun 26, 2018

nunoguedelha commented Jul 2, 2018

regarding the SWIG version

regarding the BUG

Nicogene commented Jul 2, 2018

nunoguedelha commented Jul 3, 2018

nunoguedelha commented Jul 4, 2018

Nicogene commented Jul 11, 2018 • edited Loading

traversaro commented Jul 11, 2018

drdanz commented Jul 11, 2018

traversaro commented Jul 11, 2018 • edited Loading

drdanz commented Jul 11, 2018

nunoguedelha commented Jul 11, 2018 • edited Loading

drdanz commented Jul 25, 2018

traversaro commented Jul 25, 2018

nunoguedelha commented Jul 25, 2018

drdanz commented Jul 26, 2018

Nicogene commented Jul 26, 2018

Tobias-Fischer commented Aug 15, 2018

randaz81 commented Jan 21, 2025 • edited Loading

Nicogene commented Jun 25, 2018 •

edited

Loading

Nicogene commented Jun 25, 2018 •

edited

Loading

Nicogene commented Jul 11, 2018 •

edited

Loading

traversaro commented Jul 11, 2018 •

edited

Loading

nunoguedelha commented Jul 11, 2018 •

edited

Loading

randaz81 commented Jan 21, 2025 •

edited

Loading