Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Class based implementation #9

Open
semiversus opened this issue Jan 2, 2024 · 0 comments
Open

Class based implementation #9

semiversus opened this issue Jan 2, 2024 · 0 comments

Comments

@semiversus
Copy link

I started experimenting with a class based implementation. This is not a proposal to change the API - just wanted do hear what you think. You find the implementation here: https://github.com/semiversus/eseries/tree/class_based

In case of going towards a class based implementation, it would be easy to keep the API backwards compatible by providing wrapper functions:

def find_greater_than_or_equal(series_key, value):
  return series_key.find_greater_than_or_equal(value)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant