Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version 1.0.1 has type issues #145

Open
kaiyoma opened this issue Dec 15, 2022 · 0 comments
Open

Version 1.0.1 has type issues #145

kaiyoma opened this issue Dec 15, 2022 · 0 comments

Comments

@kaiyoma
Copy link

kaiyoma commented Dec 15, 2022

The recent type changes are causing type errors when trying to use the latest version of this package:

09:10:42  node_modules/.pnpm/[email protected]_sfoxds7t5ydpegc3knd667wn6m/node_modules/react-new-window/types/NewWindow.d.ts(14,5): error TS2411: Property 'height' of type 'number | undefined' is not assignable to 'string' index type 'string | number | boolean'.
09:10:42  node_modules/.pnpm/[email protected]_sfoxds7t5ydpegc3knd667wn6m/node_modules/react-new-window/types/NewWindow.d.ts(15,5): error TS2411: Property 'width' of type 'number | undefined' is not assignable to 'string' index type 'string | number | boolean'.
abradley added a commit to abradley/react-new-window that referenced this issue Dec 20, 2022
@abradley
Fix type error in IWindowFeatures (rmariuzzo#145)
55763cc 
A TypeScript index signature for an object type must be compatible
with all properties of the object.
abradley added a commit to abradley/react-new-window that referenced this issue Dec 20, 2022
@abradley
Fix type error in IWindowFeatures (rmariuzzo#145)
c3bfe06 
A TypeScript index signature for an object type must be compatible
with all properties of the object.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kaiyoma