Improve error handling

Author: rmachielse

index.js

@@ -88,6 +88,13 @@ module.exports = {
               } else {
                 this.log('uploaded to chrome web store succesfully', { verbose: true });
               }
+            })
+            .catch((error) => {
+              if (error.response) {
+                error = `uploading to chrome web store failed: ${error.response.body.error}`;
+              }
+
+              return Promise.reject(error);
             });
         } else {
           return Promise.resolve();
@@ -108,6 +115,13 @@ module.exports = {
             .then(this._publishToChromeWebStore.bind(this, publishTarget))
             .then(() => {
               this.log('published to chrome web store succesfully', { verbose: true });
+            })
+            .catch((error) => {
+              if (error.response) {
+                error = `publishing to chrome web store failed: ${error.response.body.error}`;
+              }
+
+              return Promise.reject(error);
             });
         } else {
           return Promise.resolve();

node-tests/index-test.js

@@ -283,7 +283,21 @@ describe('ember-cli-deploy-chrome-app plugin', function() {
         return rimraf(distDir);
       });
 
-      describe('when the request fails', function() {
+      describe('when the oauth token request fails', function() {
+        beforeEach(function() {
+          nock('https://www.googleapis.com')
+            .post('/oauth2/v4/token')
+            .reply(400, {
+              error: 'invalid grant'
+            });
+        });
+
+        it('fails to upload the zip file to the chrome webstore', function() {
+          return expect(plugin.upload(context)).to.be.rejected;
+        });
+      });
+
+      describe('when the upload request fails', function() {
         beforeEach(function() {
           nock('https://www.googleapis.com')
             .post('/oauth2/v4/token')
@@ -301,7 +315,7 @@ describe('ember-cli-deploy-chrome-app plugin', function() {
         });
       });
 
-      describe('when the request succeeds', function() {
+      describe('when the upload request succeeds', function() {
         beforeEach(function() {
           nock('https://www.googleapis.com')
             .post('/oauth2/v4/token')
@@ -362,19 +376,21 @@ describe('ember-cli-deploy-chrome-app plugin', function() {
         plugin.configure(context);
       });
 
-      describe('when the request fails', function() {
+      describe('when the oauth token request fails', function() {
         beforeEach(function() {
           nock('https://www.googleapis.com')
             .post('/oauth2/v4/token')
-            .reply(401);
+            .reply(401, {
+              error: 'invalid_grant'
+            });
         });
 
         it('fails to publish to the chrome webstore', function() {
           return expect(plugin.activate(context)).to.be.rejected;
         });
       });
 
-      describe('when the request succeeds', function() {
+      describe('when the publish request succeeds', function() {
         beforeEach(function() {
           nock('https://www.googleapis.com')
             .post('/oauth2/v4/token')