Skip to content

Commit 40d7aad

Browse files
committed
Tighten parameter types on PopupBase hide methods.
RELNOTES[INC]: On goog.ui.PopupBase and goog.ui.MenuBase, the target parameters of onHide and onBeforeHide are now of type Node rather than Object. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=115343734
1 parent 17264ac commit 40d7aad

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

closure/goog/ui/menubase.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ goog.ui.MenuBase.prototype.onShow = function() {
103103
/**
104104
* Called after the menu is hidden. Derived classes can override to hook this
105105
* event but should make sure to call the parent class method.
106-
* @param {Object=} opt_target Target of the event causing the hide.
106+
* @param {?Node=} opt_target Target of the event causing the hide.
107107
* @protected
108108
* @override
109109
*/

closure/goog/ui/popupbase.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -623,7 +623,7 @@ goog.ui.PopupBase.prototype.show_ = function() {
623623
/**
624624
* Hides the popup. This call is idempotent.
625625
*
626-
* @param {Object=} opt_target Target of the event causing the hide.
626+
* @param {?Node=} opt_target Target of the event causing the hide.
627627
* @return {boolean} Whether the popup was hidden and not cancelled.
628628
* @private
629629
*/
@@ -661,7 +661,7 @@ goog.ui.PopupBase.prototype.hide_ = function(opt_target) {
661661
/**
662662
* Continues hiding the popup. This is a continuation from hide_. It is
663663
* a separate method so that we can add a transition before hiding.
664-
* @param {Object=} opt_target Target of the event causing the hide.
664+
* @param {?Node=} opt_target Target of the event causing the hide.
665665
* @private
666666
*/
667667
goog.ui.PopupBase.prototype.continueHidingPopup_ = function(opt_target) {
@@ -738,7 +738,7 @@ goog.ui.PopupBase.prototype.onShow = function() {
738738
* Called before the popup is hidden. Derived classes can override to hook this
739739
* event but should make sure to call the parent class method.
740740
*
741-
* @param {Object=} opt_target Target of the event causing the hide.
741+
* @param {?Node=} opt_target Target of the event causing the hide.
742742
* @return {boolean} If anyone called preventDefault on the event object (or
743743
* if any of the handlers returns false this will also return false.
744744
* @protected
@@ -752,7 +752,7 @@ goog.ui.PopupBase.prototype.onBeforeHide = function(opt_target) {
752752
/**
753753
* Called after the popup is hidden. Derived classes can override to hook this
754754
* event but should make sure to call the parent class method.
755-
* @param {Object=} opt_target Target of the event causing the hide.
755+
* @param {?Node=} opt_target Target of the event causing the hide.
756756
* @protected
757757
*/
758758
goog.ui.PopupBase.prototype.onHide = function(opt_target) {

0 commit comments

Comments
 (0)