TableNameBuilder: Now using UNION ALL when using data arrays to build ad-hoc tables

Author: rkrx

src/Builder/Traits/TableNameBuilder.php

@@ -34,7 +34,7 @@ protected function buildTableName(?string $alias, $name): string {
 					$parts[] = sprintf("SELECT %s", implode(', ', $values));
 				}
 			}
-			$name = '(' . implode("\n\tUNION\n\t", $parts) . ')';
+			$name = '(' . implode("\n\tUNION ALL\n\t", $parts) . ')';
 		}
 		if((is_string($name) || $name instanceof VirtualTable) && $this->db()->getVirtualTables()->has($name)) {
 			$select = (string) $this->db()->getVirtualTables()->get($name);

tests/Builder/SelectTest.php

@@ -37,7 +37,7 @@ public function testFromArray(): void {
 		->from('a', [['a' => 1, 'b' => 3], ['a' => 2, 'b' => 2], ['a' => 3, 'b' => 1]])
 		->joinInner('b', [['a' => 1, 'b' => 3], ['a' => 2, 'b' => 2], ['a' => 3, 'b' => 1]])
 		->asString();
-		self::assertEquals("SELECT\n\ta.a,\n\tb.b\nFROM\n\t(SELECT 1 AS `a`, 3 AS `b`\n\tUNION\n\tSELECT 2 AS `a`, 2 AS `b`\n\tUNION\n\tSELECT 3 AS `a`, 1 AS `b`) a\nINNER JOIN\n\t(SELECT 1 AS `a`, 3 AS `b`\n\tUNION\n\tSELECT 2 AS `a`, 2 AS `b`\n\tUNION\n\tSELECT 3 AS `a`, 1 AS `b`) b\n", $str);
+		self::assertEquals("SELECT\n\ta.a,\n\tb.b\nFROM\n\t(SELECT 1 AS `a`, 3 AS `b`\n\tUNION ALL\n\tSELECT 2 AS `a`, 2 AS `b`\n\tUNION ALL\n\tSELECT 3 AS `a`, 1 AS `b`) a\nINNER JOIN\n\t(SELECT 1 AS `a`, 3 AS `b`\n\tUNION ALL\n\tSELECT 2 AS `a`, 2 AS `b`\n\tUNION ALL\n\tSELECT 3 AS `a`, 1 AS `b`) b\n", $str);
 	}
 
 	public function testMultipleFrom(): void {
@@ -553,6 +553,6 @@ public function testArrayTables(): void {
 		->from('a', range(1, 9))
 		->asString();
 
-		self::assertEquals("SELECT\n\ta.value\nFROM\n\t(SELECT 1 AS `value`\n\tUNION\n\tSELECT 2 AS `value`\n\tUNION\n\tSELECT 3 AS `value`\n\tUNION\n\tSELECT 4 AS `value`\n\tUNION\n\tSELECT 5 AS `value`\n\tUNION\n\tSELECT 6 AS `value`\n\tUNION\n\tSELECT 7 AS `value`\n\tUNION\n\tSELECT 8 AS `value`\n\tUNION\n\tSELECT 9 AS `value`) a\n", $vt1);
+		self::assertEquals("SELECT\n\ta.value\nFROM\n\t(SELECT 1 AS `value`\n\tUNION ALL\n\tSELECT 2 AS `value`\n\tUNION ALL\n\tSELECT 3 AS `value`\n\tUNION ALL\n\tSELECT 4 AS `value`\n\tUNION ALL\n\tSELECT 5 AS `value`\n\tUNION ALL\n\tSELECT 6 AS `value`\n\tUNION ALL\n\tSELECT 7 AS `value`\n\tUNION ALL\n\tSELECT 8 AS `value`\n\tUNION ALL\n\tSELECT 9 AS `value`) a\n", $vt1);
 	}
 }