Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What does the LSTM predict? It looks like the survival rate, not the true event time. #17

Open
jialin666 opened this issue Feb 21, 2025 · 2 comments

Comments

@jialin666
Copy link

Hi there; thanks for your contribution and for sharing the code. When I review the code, I get stuck in some places. First, It looks like you treat the output of the model as the survival rate, not the probability of true event time (BASE_MODEL, line 299). Second, what confused me most is how you dealt with the output, in the function reduce_mul, the code generated production of the output from time step 0 to time step MAX_SEQ_LEN! Why is MAX_SEQ_LEN? I thought it should be the time step that the event occurred. Could you help me to resolve these confusion? Thanks!

@jialin666
Copy link
Author

Everyone is very welcome to discuss the code of this paper with me ([email protected]).

@rk2900
Copy link
Owner

rk2900 commented Feb 22, 2025

Hi,

  1. According to our paper, the hazard rate would be used for calculating the survival probability. Please read the details of our paper.
  2. Your understanding is correct. The calculation are based on the whole sequence with max sequence length. But, the results of interest at the event time are gathered later in Line 305. This is to fully utilize the parallel computation of GPU and some survival probability calculation (after the event time) would be regarded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants