Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: comapction aware disk cache region eviction #20179

Open
MrCroxx opened this issue Jan 16, 2025 · 0 comments
Open

feat: comapction aware disk cache region eviction #20179

MrCroxx opened this issue Jan 16, 2025 · 0 comments
Assignees
Milestone

Comments

@MrCroxx
Copy link
Contributor

MrCroxx commented Jan 16, 2025

Is your feature request related to a problem? Please describe.

Currently, the disk cache region to evict is picked following the 2 rules:

  1. Pick by invalid ratio > 0.8.
  2. Pick in FIFO order.

However, disk cache is currently not compaction-aware, which means the invalid ratio is only calculated by removal ratio, no compacted blocks included.

Describe the solution you'd like

Actively remove compacted blocks, or introduce a disk cache eviction picker to solve.

Describe alternatives you've considered

No response

Additional context

No response

@MrCroxx MrCroxx self-assigned this Jan 16, 2025
@MrCroxx MrCroxx added this to the future-release-2.4 milestone Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant