Open
Description
The phase output of the generator currently can only range from -1 to 1, which is not enough as full phase in radians is expected later in stft.inverse()
(either 0..2*pi or -pi..pi).
The paper mentions somewhat cryptically that "we apply a sine activation function to represent the periodic characteristics of the phase spectrogram", but in any regard the current implementation is faulty since it can not represent the full range of possible phases.
Line 118 in ecbf0f6
As a suggestion, either try scaling the output by 2*pi, or directly predicting sin(phase) and cos(phase) in the generator (the predicted values can be normalized by dividing both by sin(phase)**2 + cos(phase)**2
).
Metadata
Metadata
Assignees
Labels
No labels