Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement suggestions #37

Open
PacoVu opened this issue Nov 29, 2021 · 0 comments
Open

Improvement suggestions #37

PacoVu opened this issue Nov 29, 2021 · 0 comments

Comments

@PacoVu
Copy link

PacoVu commented Nov 29, 2021

  • Should provide a sugar method for update an adaptive card. This may require the sendAdaptiveCard method to return a card id or the bot framework keep a list of card ids.
  • Should provide a sugar method to delete an old subscription (due to changing Webhook address)
Bot.prototype.deleteSubscription = async function (subscriptionId) {
    await this.rc.delete(`/restapi/v1.0/subscription/${subscriptionId}`);
};
  • Sugar method 'setupWebHook' should be changed to 'setupWebHookSubscription' to be more informative.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant