Skip to content

Commit 8a70e26

Browse files
authored
Use numeric instead of number in random_password resource (#13)
* chore: update repo for pre-commit-terraform * chore: update version for pre-commit-terraform * chore: add args to terraform_docs pre-commit * docs: escape _ characters * fix: use numeric instead of number
1 parent 9fb44fb commit 8a70e26

File tree

3 files changed

+18
-5
lines changed

3 files changed

+18
-5
lines changed

.pre-commit-config.yaml

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,14 @@
11
---
22
repos:
3-
- repo: git://github.com/antonbabenko/pre-commit-terraform
4-
rev: v1.50.0
3+
- repo: https://github.com/antonbabenko/pre-commit-terraform
4+
rev: v1.74.1
55
hooks:
66
- id: terraform_fmt
77
- id: terraform_docs
8+
args:
9+
- --args=--anchor=false
10+
- --args=--html=false
11+
- --args=--hide=modules
812
- repo: https://github.com/pre-commit/pre-commit-hooks
913
rev: v3.4.0
1014
hooks:

README.md

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,16 @@ module "random_password" {
3030
| aws | n/a |
3131
| random | >= 2.2.0 |
3232

33+
## Resources
34+
35+
| Name | Type |
36+
|------|------|
37+
| [aws_cloudwatch_log_metric_filter.secret_access](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/cloudwatch_log_metric_filter) | resource |
38+
| [aws_cloudwatch_metric_alarm.unauthorized_cloudtrail_calls](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/cloudwatch_metric_alarm) | resource |
39+
| [aws_secretsmanager_secret.secret](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/secretsmanager_secret) | resource |
40+
| [aws_secretsmanager_secret_version.secret_val](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/secretsmanager_secret_version) | resource |
41+
| [random_password.random_string](https://registry.terraform.io/providers/hashicorp/random/latest/docs/resources/password) | resource |
42+
3343
## Inputs
3444

3545
| Name | Description | Type | Default | Required |
@@ -48,7 +58,7 @@ module "random_password" {
4858
| name\_prefix | Name Prefix (not used if name specified) | `string` | `"terraform"` | no |
4959
| override\_special | n/a | `string` | `""` | no |
5060
| pass\_version | Password version. Increment this to trigger a new password. | `number` | `1` | no |
51-
| recovery_window_in_days | Number of days to wait before deleting the secret | `number` | `"30"` | no |
61+
| recovery\_window\_in\_days | Number of days that AWS Secrets Manager waits before it can delete the secret. | `number` | `30` | no |
5262
| secret\_access\_metric\_namespace | Metric namespace to use for CloudWatch metric | `string` | `"SecretsManager"` | no |
5363
| secret\_access\_notification\_arn | SNS topic to notify on secret access (required if `enable_secret_access_notification=true`) | `string` | `""` | no |
5464
| tags | Tags to add to supported resources | `map(string)` | `{}` | no |
@@ -64,7 +74,6 @@ module "random_password" {
6474
| secret | Generated secret |
6575
| secret\_arn | The ARN of the secret |
6676
| version\_id | The unique identifier of the version of the secret. |
67-
6877
<!-- END OF PRE-COMMIT-TERRAFORM DOCS HOOK -->
6978

7079
## Warning

main.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ resource "random_password" "random_string" {
88
count = var.create_secret ? 1 : 0
99
length = var.length
1010
lower = var.use_lower
11-
number = var.use_number
11+
numeric = var.use_number
1212
min_lower = var.min_lower
1313
min_numeric = var.min_numeric
1414
min_special = var.min_special

0 commit comments

Comments
 (0)