Skip to content

Commit 16956b5

Browse files
committed
fix: address remaining review nits and clarify withContainer docs
- Remove comment-only cmd_contract_mock_test.go (rationale moved to PR) - Revert whitespace-only alignment in writer_agenteditor_agent.go - Clarify withContainer doc comment per review feedback
1 parent 181e688 commit 16956b5

3 files changed

Lines changed: 16 additions & 23 deletions

File tree

mdl/executor/cmd_contract_mock_test.go

Lines changed: 0 additions & 9 deletions
This file was deleted.

mdl/executor/mock_test_helpers_test.go

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -94,8 +94,10 @@ func mkHierarchy(modules ...*model.Module) *ContainerHierarchy {
9494
return h
9595
}
9696

97-
// withContainer registers a document (entity, enumeration, etc.) as belonging
98-
// to a parent container (module or folder) in the hierarchy.
97+
// withContainer registers a container-parent link so that
98+
// ContainerHierarchy.FindModuleID can walk up from childID to a module.
99+
// childID is the element's own ID; parentID is the module (or folder) it
100+
// belongs to.
99101
func withContainer(h *ContainerHierarchy, childID, parentID model.ID) {
100102
h.containerParent[childID] = parentID
101103
}

sdk/mpr/writer_agenteditor_agent.go

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -82,19 +82,19 @@ func encodeAgentContents(a *agenteditor.Agent) (string, error) {
8282
MaxResults int `json:"maxResults,omitempty"`
8383
}
8484
type contentsShape struct {
85-
Description string `json:"description"`
86-
SystemPrompt string `json:"systemPrompt"`
87-
UserPrompt string `json:"userPrompt"`
88-
UsageType string `json:"usageType"`
85+
Description string `json:"description"`
86+
SystemPrompt string `json:"systemPrompt"`
87+
UserPrompt string `json:"userPrompt"`
88+
UsageType string `json:"usageType"`
8989
Variables []agenteditor.AgentVar `json:"variables"`
90-
Tools []toolEntry `json:"tools"`
91-
KnowledgebaseTools []kbToolEntry `json:"knowledgebaseTools"`
92-
Model *agenteditor.DocRef `json:"model,omitempty"`
93-
Entity *agenteditor.DocRef `json:"entity,omitempty"`
94-
MaxTokens *int `json:"maxTokens,omitempty"`
95-
ToolChoice string `json:"toolChoice,omitempty"`
96-
Temperature *float64 `json:"temperature,omitempty"`
97-
TopP *float64 `json:"topP,omitempty"`
90+
Tools []toolEntry `json:"tools"`
91+
KnowledgebaseTools []kbToolEntry `json:"knowledgebaseTools"`
92+
Model *agenteditor.DocRef `json:"model,omitempty"`
93+
Entity *agenteditor.DocRef `json:"entity,omitempty"`
94+
MaxTokens *int `json:"maxTokens,omitempty"`
95+
ToolChoice string `json:"toolChoice,omitempty"`
96+
Temperature *float64 `json:"temperature,omitempty"`
97+
TopP *float64 `json:"topP,omitempty"`
9898
}
9999

100100
// Convert typed slices (ensure non-nil so JSON emits [] not null).

0 commit comments

Comments
 (0)