refactor: introduce LintReader interface, remove sdk/mpr from linter and executor

Author: retran

cmd/mxcli/cmd_lint.go

@@ -120,14 +120,9 @@ Examples:
 		}
 
 		// Create lint context
-		ctx := linter.NewLintContext(cat)
+		ctx := linter.NewLintContext(cat, exec.Backend())
 		ctx.SetExcludedModules(excludeModules)
 
-		// Set reader so rules that inspect raw BSON (MPR004, MPR005) work
-		if reader := exec.Reader(); reader != nil {
-			ctx.SetReader(reader)
-		}
-
 		// Create linter and register rules
 		lint := linter.New(ctx)
 		lint.AddRule(rules.NewNamingConventionRule())

cmd/mxcli/cmd_report.go

@@ -78,14 +78,9 @@ Examples:
 		}
 
 		// Create lint context
-		ctx := linter.NewLintContext(cat)
+		ctx := linter.NewLintContext(cat, exec.Backend())
 		ctx.SetExcludedModules(excludeModules)
 
-		// Set reader so rules that inspect raw BSON work
-		if reader := exec.Reader(); reader != nil {
-			ctx.SetReader(reader)
-		}
-
 		// Create linter and register all rules
 		lint := linter.New(ctx)
 

mdl/executor/cmd_lint.go

@@ -33,8 +33,7 @@ func execLint(ctx *ExecContext, s *ast.LintStmt) error {
 	}
 
 	// Create lint context
-	lintCtx := linter.NewLintContext(ctx.Catalog)
-	lintCtx.SetReader(ctx.Reader())
+	lintCtx := linter.NewLintContext(ctx.Catalog, ctx.Backend)
 
 	// Load configuration
 	projectDir := filepath.Dir(ctx.MprPath)

mdl/executor/exec_context.go

@@ -12,7 +12,6 @@ import (
 	"github.com/mendixlabs/mxcli/mdl/catalog"
 	"github.com/mendixlabs/mxcli/mdl/diaglog"
 	"github.com/mendixlabs/mxcli/model"
-	"github.com/mendixlabs/mxcli/sdk/mpr"
 	sqllib "github.com/mendixlabs/mxcli/sql"
 )
 
@@ -215,19 +214,3 @@ func (ctx *ExecContext) ensureSqlMgr() *sqllib.Manager {
 	}
 	return ctx.SqlMgr
 }
-
-// Reader returns the MPR reader, or nil if not connected.
-// Deprecated: External callers should migrate to using Backend methods directly.
-// TODO(shared-types): remove once all callers use Backend — target: v0.next milestone.
-func (ctx *ExecContext) Reader() *mpr.Reader {
-	if ctx.Backend == nil {
-		return nil
-	}
-	type readerProvider interface {
-		MprReader() *mpr.Reader
-	}
-	if rp, ok := ctx.Backend.(readerProvider); ok {
-		return rp.MprReader()
-	}
-	return nil
-}

mdl/executor/executor.go

@@ -18,7 +18,6 @@ import (
 	"github.com/mendixlabs/mxcli/mdl/types"
 	"github.com/mendixlabs/mxcli/model"
 	"github.com/mendixlabs/mxcli/sdk/domainmodel"
-	"github.com/mendixlabs/mxcli/sdk/mpr"
 	sqllib "github.com/mendixlabs/mxcli/sql"
 )
 
@@ -309,27 +308,16 @@ func (e *Executor) Catalog() *catalog.Catalog {
 	return c
 }
 
-// Reader returns the MPR reader, or nil if not connected.
-// Deprecated: External callers should migrate to using Backend methods directly.
-// TODO(shared-types): remove once all callers use Backend — target: v0.next milestone.
-func (e *Executor) Reader() *mpr.Reader {
-	if e.backend == nil {
-		return nil
-	}
-	type readerProvider interface {
-		MprReader() *mpr.Reader
-	}
-	if rp, ok := e.backend.(readerProvider); ok {
-		return rp.MprReader()
-	}
-	return nil
-}
-
 // IsConnected returns true if connected to a project.
 func (e *Executor) IsConnected() bool {
 	return e.backend != nil && e.backend.IsConnected()
 }
 
+// Backend returns the full backend, or nil if not connected.
+func (e *Executor) Backend() backend.FullBackend {
+	return e.backend
+}
+
 // Close closes the connection to the project and all SQL connections.
 func (e *Executor) Close() error {
 	var closeErr error

mdl/linter/context.go

@@ -7,33 +7,45 @@ import (
 	"iter"
 
 	"github.com/mendixlabs/mxcli/mdl/catalog"
-	"github.com/mendixlabs/mxcli/sdk/mpr"
+	"github.com/mendixlabs/mxcli/mdl/types"
+	"github.com/mendixlabs/mxcli/model"
+	"github.com/mendixlabs/mxcli/sdk/microflows"
+	"github.com/mendixlabs/mxcli/sdk/pages"
+	"github.com/mendixlabs/mxcli/sdk/security"
 )
 
+// LintReader provides read access to MPR document data needed by lint rules.
+// Implemented by MprBackend (and any backend satisfying these signatures).
+type LintReader interface {
+	GetMicroflow(id model.ID) (*microflows.Microflow, error)
+	GetProjectSecurity() (*security.ProjectSecurity, error)
+	GetNavigation() (*types.NavigationDocument, error)
+	ListPages() ([]*pages.Page, error)
+	ListModules() ([]*model.Module, error)
+	ListFolders() ([]*types.FolderInfo, error)
+	GetRawUnit(id model.ID) (map[string]any, error)
+}
+
 // LintContext wraps a catalog and provides rule-friendly APIs.
 type LintContext struct {
 	catalog  *catalog.Catalog
 	db       catalog.CatalogDB
 	excluded map[string]bool
-	reader   *mpr.Reader
-}
-
-// SetReader sets the MPR reader for rules that need to inspect full document data.
-func (ctx *LintContext) SetReader(reader *mpr.Reader) {
-	ctx.reader = reader
+	reader   LintReader
 }
 
-// Reader returns the MPR reader, or nil if not set.
-func (ctx *LintContext) Reader() *mpr.Reader {
+// Reader returns the LintReader, or nil if not set.
+func (ctx *LintContext) Reader() LintReader {
 	return ctx.reader
 }
 
-// NewLintContext creates a new LintContext from a catalog.
-func NewLintContext(cat *catalog.Catalog) *LintContext {
+// NewLintContext creates a new LintContext from a catalog and an optional reader.
+func NewLintContext(cat *catalog.Catalog, reader LintReader) *LintContext {
 	return &LintContext{
 		catalog:  cat,
 		db:       cat.CatalogDB(),
 		excluded: make(map[string]bool),
+		reader:   reader,
 	}
 }
 

mdl/linter/rules/page_navigation_security.go

@@ -8,7 +8,6 @@ import (
 
 	"github.com/mendixlabs/mxcli/mdl/linter"
 	"github.com/mendixlabs/mxcli/mdl/types"
-	"github.com/mendixlabs/mxcli/sdk/mpr"
 )
 
 // PageNavigationSecurityRule checks that pages used in navigation have at least
@@ -134,7 +133,7 @@ func collectMenuPages(items []*types.NavMenuItem, profileName string, navPages m
 }
 
 // buildPageRoleCountMap builds a map of qualified page name → number of allowed roles.
-func buildPageRoleCountMap(reader *mpr.Reader) map[string]int {
+func buildPageRoleCountMap(reader linter.LintReader) map[string]int {
 	result := make(map[string]int)
 
 	pages, err := reader.ListPages()