Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAYW formatted-citation does not use current output formatted citation #2757

Closed
newhallroad opened this issue Jan 22, 2024 · 20 comments
Closed
Labels

Comments

@newhallroad
Copy link

Debug log ID

HWAWCS9F-euc/6.7.143-6

What happened?

From the cli,curl "http://127.0.0.1:23119/better-bibtex/cayw?selected=true&format=formatted-citation" works exactly as expected. It returns the currently selected item in the format set in the current Zotero quick-export setting. In my example, it's a csl I modifed from Chicago full-note, with HTML: Rahel Jaeggi, <i>Critique of Forms of Life</i> (Cambridge, MA: Harvard University Press, 2018).

However, if I remove selected=true there is unexpected behavior. curl "http://127.0.0.1:23119/better-bibtex/cayw?format=formatted-citation" brings up the cayw input. When I select that same book, it returns (Jaeggi, 2018). I'm not sure what csl style this is. (Chicago shouldn't have the comma there.) In any case, it's not the selected format as far as I can see.

The debug log is from calling these two commands in the order described above.
Thank you as ever for your wonderful work.

retorquere added a commit that referenced this issue Jan 24, 2024
Copy link

🤖 this is your friendly neighborhood build bot announcing test build 6.7.144.2757.5671 ("logging for #2757")

Install in Zotero by downloading test build 6.7.144.2757.5671, opening the Zotero "Tools" menu, selecting "Add-ons", open the gear menu in the top right, and select "Install Add-on From File...".

@retorquere
Copy link
Owner

It's actually the first that seems wrong, that's the output of formatted-bibliography, not formatted-citation. I can see in HWAWCS9F-euc/6.7.143-6 though that you made the right API call, but I can't replicate the problem on my end. Can you install build 5671, replay your scenario, and send a new log?

@newhallroad
Copy link
Author

Befpre I install the new build, let me just check something with you, because I think that citation format is actually correct for this csl. Is it possible the confusion is that I am using a full note csl rather than author-date?

For example, if I run the command curl "http://127.0.0.1:23119/better-bibtex/cayw?selected=true&format=formatted-citation", the output is as follows.
With export style "Chicago Manual of Style 17th edition (note)":
Jaeggi, <i>Critique of Forms of Life</i>.
With export style "Chicago Manual of Style 17th edition (full note)":
Rahel Jaeggi, <i>Critique of Forms of Life</i> (Cambridge, MA: Harvard University Press, 2018).
With export style "Chicago Manual of Style 17th edition (author date)":
(Jaeggi 2018)

However, if I run curl "http://127.0.0.1:23119/better-bibtex/cayw?format=formatted-citation" and select the same item from the input, then the output is (Jaeggi, 2018), irrespective of what export style is selected.

For what it's worth, that seems to be the correct syntax for the American Psychoanalytical Association, but I have no idea why that should be relevant.

I just thought it would be helpful to first offer that information. If you would like me to use your new build, please say so and I'll go ahead and do so. Thank you.

@retorquere
Copy link
Owner

If those are correct in-text citation formats, I will believe you. I would still need a log from 5671 to explain the difference you are seeing.

@newhallroad
Copy link
Author

OK, thank you.
I submitted log 9CSQCXQC-euc/6.7.144.2757.5671-6 from 6571.
The commands were in the following order:
curl "http://127.0.0.1:23119/better-bibtex/cayw?selected=true&format=formatted-citation"
curl "http://127.0.0.1:23119/better-bibtex/cayw?format=formatted-citation"
"Chicago Manual of Style 17th edition (note)" is the selected export style.

Copy link

🤖 this is your friendly neighborhood build bot announcing test build 6.7.146.2757.5712 ("more logging")

Install in Zotero by downloading test build 6.7.146.2757.5712, opening the Zotero "Tools" menu, selecting "Add-ons", open the gear menu in the top right, and select "Install Add-on From File...".

@retorquere
Copy link
Owner

please again with 5712

@newhallroad
Copy link
Author

Done.
X3P4J48P-euc/6.7.146.2757.5712-6
Thank you.

Copy link

🤖 this is your friendly neighborhood build bot announcing test build 6.7.147.2757.5720 ("fixes #2757")

This update may name other issues, but the build just dropped here is for you; it just means problems already fixed in other issues have been folded into the work we are doing here. Install in Zotero by downloading test build 6.7.147.2757.5720, opening the Zotero "Tools" menu, selecting "Add-ons", open the gear menu in the top right, and select "Install Add-on From File...".

@retorquere
Copy link
Owner

Can you try build 5720?

@newhallroad
Copy link
Author

Sorry for the delay. It's fixed!!!
log #D1990912389
Many thanks.

@github-actions github-actions bot reopened this Jan 29, 2024
@retorquere
Copy link
Owner

Can't see those logs, but thanks for the confirmation -- a release build is running through the tests.

@newhallroad
Copy link
Author

I'm sorry for opening this up again.
test build 6.7.147.2757.5720 worked perfectly, but the latest release 6.7.151 has reverted back to the old problem. If I'm reading the logs wrong and it's just that the patch hasn't been merged yet, I apologize. But if you expected this to be fixed in the latest build I thought you would like to know.

@retorquere
Copy link
Owner

The change was merged, so I will need a new debug log (not a D<number> log, I have no access to those).

@newhallroad
Copy link
Author

Done.
4NEMQ238-euc/6.7.151-6
Thank you.

Copy link

github-actions bot commented Feb 5, 2024

🤖 this is your friendly neighborhood build bot announcing test build 6.7.154.2757.5781 ("more logging")

This update may name other issues, but the build just dropped here is for you; it just means problems already fixed in other issues have been folded into the work we are doing here. Install in Zotero by downloading test build 6.7.154.2757.5781, opening the Zotero "Tools" menu, selecting "Add-ons", open the gear menu in the top right, and select "Install Add-on From File...".

@newhallroad
Copy link
Author

Still not working
63FJDE37-euc/6.7.154.2757.5781-6

Copy link

github-actions bot commented Feb 5, 2024

🤖 this is your friendly neighborhood build bot announcing test build 6.7.154.2757.5782 ("return style url")

This update may name other issues, but the build just dropped here is for you; it just means problems already fixed in other issues have been folded into the work we are doing here. Install in Zotero by downloading test build 6.7.154.2757.5782, opening the Zotero "Tools" menu, selecting "Add-ons", open the gear menu in the top right, and select "Install Add-on From File...".

@newhallroad
Copy link
Author

newhallroad commented Feb 5, 2024

OK, I think that solved it. Thank you again. If you like, I'll check again when the new release is pushed.

@retorquere
Copy link
Owner

New release coming up.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants