Skip to content
This repository has been archived by the owner on Mar 12, 2020. It is now read-only.

Ignore retestId when generating checksum from serializables SutState and Action #33

Closed
tdauth opened this issue Apr 10, 2019 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@tdauth
Copy link
Contributor

tdauth commented Apr 10, 2019

Apparently the field Element.retestId is generated with random values and is not the same every time. We have to filter it when generating the hash value or make sure that Surili does always generate the same value.

@tdauth tdauth added the bug Something isn't working label Apr 10, 2019
@tdauth tdauth self-assigned this Apr 10, 2019
@beatngu13
Copy link
Contributor

I recently created this PR on Bitbucket:

https://bitbucket.org/retest/surili/pull-requests/38/

I thought about this twice and I'm unsure if this isn't something we should "simply" do on the SUT model-side. That is, when we create the hash, we should ignore it.

What do you think?

@tdauth
Copy link
Contributor Author

tdauth commented Apr 14, 2019

We can do this if there is a way to exclude the field for serialization. I have only found transient.
Alternatives are to create a custom byte stream with all data except the retestId, to copy the whole SutState except the retestId in a new SutState or to create a custom state class for the monkey.

@tdauth
Copy link
Contributor Author

tdauth commented Jun 11, 2019

Surili uses a FakeRetestIdProvider. Hence, the retestId will always be the same.

@tdauth tdauth closed this as completed Jun 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Development

No branches or pull requests

2 participants