Skip to content
This repository has been archived by the owner on Mar 12, 2020. It is now read-only.

Remove unnecessary helper methods #28

Closed
tdauth opened this issue Apr 3, 2019 · 0 comments
Closed

Remove unnecessary helper methods #28

tdauth opened this issue Apr 3, 2019 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@tdauth
Copy link
Contributor

tdauth commented Apr 3, 2019

If the following methods are not used anywhere, remove them:

trait GuiStateMachine {
  def getAllExploredActions: Set[Action]
  def getActionExecutionTime: Map[Action, Int]
}

They have only been added due to legacy code.

Then we can use a TrieMap or concurrent hash map for the states and remove synchronized.

We can also remove the execution counter for the action transitions and use a TrieMap here, too.

@tdauth tdauth added the enhancement New feature or request label Apr 3, 2019
@tdauth tdauth self-assigned this Apr 3, 2019
tdauth added a commit that referenced this issue Apr 9, 2019
These methods existed due to the legacy code.
tdauth added a commit that referenced this issue Apr 10, 2019
These methods existed due to the legacy code.
tdauth added a commit that referenced this issue Apr 10, 2019
tdauth added a commit that referenced this issue Apr 10, 2019
@tdauth tdauth closed this as completed Apr 10, 2019
tdauth added a commit that referenced this issue Apr 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Development

No branches or pull requests

1 participant