fix: always show warnings for missing files regardless of location

Author: glennreyes

packages/react-email/src/utils/preview/hot-reloading/create-dependency-graph.spec.ts

@@ -144,44 +144,4 @@ import {} from './file-b';
     ).not.toContain(pathToTemporaryFile);
   });
 
-  it.sequential(
-    'does not warn when dependency outside the directory is missing an index file',
-    async () => {
-      const pathToOutsideDirectory = path.resolve(
-        testingDiretctory,
-        '../.temporary-outside-directory',
-      );
-      const pathToImporter = path.join(
-        testingDiretctory,
-        '.temporary-outside-import.ts',
-      );
-
-      await fs.mkdir(pathToOutsideDirectory, { recursive: true });
-      await fs.writeFile(
-        pathToImporter,
-        `import '../.temporary-outside-directory';\n`,
-        'utf8',
-      );
-
-      const outsideDirectoryModule: DependencyGraph[number] = {
-        path: pathToOutsideDirectory,
-        dependencyPaths: [],
-        dependentPaths: [],
-        moduleDependencies: [],
-      };
-
-      dependencyGraph[pathToOutsideDirectory] = outsideDirectoryModule;
-
-      try {
-        await updateDependencyGraph('add', pathToImporter);
-      } finally {
-        await updateDependencyGraph('unlink', pathToImporter);
-        await fs.rm(pathToImporter, { force: true });
-        delete dependencyGraph[pathToOutsideDirectory];
-        if (existsSync(pathToOutsideDirectory)) {
-          await fs.rm(pathToOutsideDirectory, { recursive: true, force: true });
-        }
-      }
-    },
-  );
 });

packages/react-email/src/utils/preview/hot-reloading/create-dependency-graph.ts

@@ -42,15 +42,6 @@ const isJavascriptModule = (filePath: string) => {
   return javascriptExtensions.includes(extensionName);
 };
 
-const isInsideDirectory = (baseDirectory: string, targetPath: string) => {
-  const relativePath = path.relative(baseDirectory, targetPath);
-
-  return (
-    relativePath === '' ||
-    (!relativePath.startsWith('..') && !path.isAbsolute(relativePath))
-  );
-};
-
 const checkFileExtensionsUntilItExists = (
   pathWithoutExtension: string,
 ): string | undefined => {
@@ -88,7 +79,6 @@ const checkFileExtensionsUntilItExists = (
  * so that it doesn't need to recompute the entire dependency graph but only the parts changed.
  */
 export const createDependencyGraph = async (directory: string) => {
-  const normalizedDirectory = path.resolve(directory);
   const filePaths = await readAllFilesInsideDirectory(directory);
   const modulePaths = filePaths.filter(isJavascriptModule);
   const graph: DependencyGraph = Object.fromEntries(
@@ -146,16 +136,9 @@ export const createDependencyGraph = async (directory: string) => {
           if (pathWithExtension) {
             pathToDependencyFromDirectory = pathWithExtension;
           } else {
-            if (
-              isInsideDirectory(
-                normalizedDirectory,
-                pathToDependencyFromDirectory,
-              )
-            ) {
-              console.warn(
-                `Could not find index file for directory at ${pathToDependencyFromDirectory}. This is probably going to cause issues with both hot reloading and your code.`,
-              );
-            }
+            console.warn(
+              `Could not find index file for directory at ${pathToDependencyFromDirectory}. This is probably going to cause issues with both hot reloading and your code.`,
+            );
           }
         }
 
@@ -180,16 +163,9 @@ export const createDependencyGraph = async (directory: string) => {
         if (pathWithEnsuredExtension) {
           pathToDependencyFromDirectory = pathWithEnsuredExtension;
         } else {
-          if (
-            isInsideDirectory(
-              normalizedDirectory,
-              pathToDependencyFromDirectory,
-            )
-          ) {
-            console.warn(
-              `Could not find file at ${pathToDependencyFromDirectory}`,
-            );
-          }
+          console.warn(
+            `Could not find file at ${pathToDependencyFromDirectory}`,
+          );
         }
 
         return pathToDependencyFromDirectory;