Use new representaiton where args are strings not numbers.

Instead of using 0, 1, 2 for variant arguments, use "Arg0", "Arg1", "Arg2".
This avoids the perf issues with `record_bench.js`, in fact the test becomes faster.

Author: cristianoc

jscomp/core/js_exp_make.ml

@@ -186,16 +186,16 @@ let make_block ?comment
     let name = match Lam_compile_util.comment_of_tag_info tag_info with
     | Some s -> s
     | None -> assert false in
-    {
+    (* {
       expression_desc = Caml_block( es, mutable_flag, str name, tag_info) ;
       comment 
-    }
-    (* let comment = Some "constructor" in
+    } *)
+    let comment = Some "constructor" in
     let property_map = [
       ("tag", str name);
       ]
-      @ List.mapi (fun n e -> (string_of_int n, e)) es in
-    {expression_desc = Object property_map; comment} *)
+      @ List.mapi (fun n e -> ("Arg" ^ string_of_int n, e)) es in
+    {expression_desc = Object property_map; comment}
   | _ -> 
   let comment = 
     match comment with 

jscomp/core/js_of_lam_block.ml

@@ -61,6 +61,8 @@ let field (field_info : Lam_compat.field_dbg_info) e i =
     -> E.array_index_by_int ~comment e i
   | Fld_module name
     -> E.module_access e name i
+  | Fld_arg pos
+    -> E.dot e ("Arg" ^ string_of_int pos)
 let field_by_exp e i = 
   E.array_index e i 
 

jscomp/core/js_of_lam_float_record.ml

@@ -31,7 +31,8 @@ module E = Js_exp_make
 
 let get_double_feild (field_info : Lam_compat.field_dbg_info) e i = 
   match field_info with 
-  | Fld_na -> 
+  | Fld_na
+  | Fld_arg _ -> 
     E.array_index_by_int e i 
 #if OCAML_VERSION =~ ">4.03.0" then 
   | Fld_record_inline s

jscomp/core/js_of_lam_record.ml

@@ -43,7 +43,8 @@ module E = Js_exp_make
 
 let field (field_info : Lam_compat.field_dbg_info) e i =
   match field_info with 
-  | Fld_na -> 
+  | Fld_na
+  | Fld_arg _ -> 
     E.array_index_by_int e i 
 #if OCAML_VERSION =~ ">4.03.0" then
   | Fld_record_inline s

jscomp/core/lam_compat.ml

@@ -185,7 +185,8 @@ type meth_kind = Lambda.meth_kind
 type field_dbg_info = Lambda.field_dbg_info =
   | Fld_na
   | Fld_record of string
-  | Fld_module of string 
+  | Fld_module of string
+  | Fld_arg of int
 #if OCAML_VERSION =~ ">4.03.0"  then 
   | Fld_record_inline of string 
   | Fld_record_extension of string 

jscomp/core/lam_compat.mli

@@ -86,7 +86,8 @@ type meth_kind = Lambda.meth_kind
 type field_dbg_info = Lambda.field_dbg_info =
   | Fld_na
   | Fld_record of string
-  | Fld_module of string 
+  | Fld_module of string
+  | Fld_arg of int
 #if OCAML_VERSION =~ ">4.03.0"  then 
   | Fld_record_inline of string 
   | Fld_record_extension of string 

jscomp/core/lam_print.ml

@@ -153,6 +153,8 @@ let primitive ppf (prim : Lam_primitive.t) = match prim with
     -> fprintf ppf "field %s/%i" s n
   | Pfield (n, Fld_na) 
     -> fprintf ppf "field %i" n
+  | Pfield (n, Fld_arg _) 
+    -> fprintf ppf "field_arg %i" n
   | Pfield_computed -> 
     fprintf ppf "field_computed"
   | Psetfield_computed -> 

jscomp/others/belt_List.ml

@@ -73,12 +73,20 @@ external mutableCell :
 *)
 external unsafeMutateTail :
   'a t -> 'a t -> unit = "#setfield1"
+let unsafeMutateTail0 = fun%raw l x ->  {|
+  l.Arg1 = x;
+|}
+let unsafeMutateTail : 'a t -> 'a t -> unit = unsafeMutateTail0
 (*
    - the cell is not empty
    - it is mutated
 *)
 external unsafeTail :
   'a t -> 'a t = "%field1"
+let unsafeTail0 = fun%raw l ->  {|
+  return l.Arg1
+|}
+let unsafeTail : 'a t -> 'a t = unsafeTail0
 (*
    - the cell is not empty
 *)

jscomp/runtime/release.ninja

@@ -40,7 +40,7 @@ build runtime/caml_int32.cmj : cc_cmi runtime/caml_int32.ml | runtime/caml_built
 build runtime/caml_int32.cmi : cc runtime/caml_int32.mli | runtime/bs_stdlib_mini.cmi runtime/js.cmi runtime/js.cmj
 build runtime/caml_int64.cmj : cc_cmi runtime/caml_int64.ml | runtime/caml_builtin_exceptions.cmj runtime/caml_char.cmj runtime/caml_float.cmj runtime/caml_float_extern.cmj runtime/caml_int32.cmj runtime/caml_int64.cmi runtime/caml_nativeint_extern.cmj runtime/caml_primitive.cmj runtime/caml_string_extern.cmj runtime/caml_utils.cmj runtime/js.cmj
 build runtime/caml_int64.cmi : cc runtime/caml_int64.mli | runtime/bs_stdlib_mini.cmi runtime/js.cmi runtime/js.cmj
-build runtime/caml_io.cmj : cc_cmi runtime/caml_io.ml | runtime/block.cmj runtime/caml_io.cmi runtime/caml_string_extern.cmj runtime/caml_undefined_extern.cmj runtime/curry.cmj runtime/js.cmj
+build runtime/caml_io.cmj : cc_cmi runtime/caml_io.ml | runtime/caml_io.cmi runtime/caml_string_extern.cmj runtime/caml_undefined_extern.cmj runtime/curry.cmj runtime/js.cmj
 build runtime/caml_io.cmi : cc runtime/caml_io.mli | runtime/bs_stdlib_mini.cmi runtime/caml_undefined_extern.cmj runtime/js.cmi runtime/js.cmj
 build runtime/caml_lexer.cmj : cc_cmi runtime/caml_lexer.ml | runtime/caml_builtin_exceptions.cmj runtime/caml_lexer.cmi
 build runtime/caml_lexer.cmi : cc runtime/caml_lexer.mli | runtime/bs_stdlib_mini.cmi runtime/js.cmi runtime/js.cmj

jscomp/test/a_filename_test.js

@@ -2,7 +2,6 @@
 
 var Mt = require("./mt.js");
 var $$Array = require("../../lib/js/array.js");
-var Block = require("../../lib/js/block.js");
 var Ext_filename_test = require("./ext_filename_test.js");
 
 var suites = /* record */[/* contents */"[]"];
@@ -11,18 +10,20 @@ var test_id = /* record */[/* contents */0];
 
 function eq(loc, x, y) {
   test_id[0] = test_id[0] + 1 | 0;
-  suites[0] = Block.__("::", [
-      /* tuple */[
-        loc + (" id " + String(test_id[0])),
-        (function (param) {
-            return Block.__("Eq", [
-                      x,
-                      y
-                    ]);
-          })
-      ],
-      suites[0]
-    ]);
+  suites[0] = /* constructor */{
+    tag: "::",
+    Arg0: /* tuple */[
+      loc + (" id " + String(test_id[0])),
+      (function (param) {
+          return /* constructor */{
+                  tag: "Eq",
+                  Arg0: x,
+                  Arg1: y
+                };
+        })
+    ],
+    Arg1: suites[0]
+  };
   return /* () */0;
 }