Skip to content

Commit 0fff45a

Browse files
authored
Show deprecation warnings for local deps only (#7724)
* Show deprecation warnings for local deps only * CHANGELOG
1 parent 7c6f354 commit 0fff45a

File tree

2 files changed

+17
-15
lines changed

2 files changed

+17
-15
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
#### :nail_care: Polish
1616

1717
- Apply heuristic to suggest using JSX fragments where we guess that might be what the user wanted. https://github.com/rescript-lang/rescript/pull/7714
18+
- Show deprecation warnings for `bs-dependencies` etc. for local dependencies only. https://github.com/rescript-lang/rescript/pull/7724
1819

1920
#### :bug: Bug fix
2021

rewatch/src/build.rs

Lines changed: 16 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -465,21 +465,22 @@ pub fn incremental_build(
465465

466466
fn log_deprecations(build_state: &BuildState) {
467467
build_state.packages.iter().for_each(|(_, package)| {
468-
package
469-
.config
470-
.get_deprecations()
471-
.iter()
472-
.for_each(|deprecation_warning| match deprecation_warning {
473-
config::DeprecationWarning::BsDependencies => {
474-
log_deprecated_config_field(&package.name, "bs-dependencies", "dependencies");
475-
}
476-
config::DeprecationWarning::BsDevDependencies => {
477-
log_deprecated_config_field(&package.name, "bs-dev-dependencies", "dev-dependencies");
478-
}
479-
config::DeprecationWarning::BscFlags => {
480-
log_deprecated_config_field(&package.name, "bsc-flags", "compiler-flags");
481-
}
482-
});
468+
// Only warn for local dependencies, not external packages
469+
if package.is_local_dep {
470+
package.config.get_deprecations().iter().for_each(
471+
|deprecation_warning| match deprecation_warning {
472+
config::DeprecationWarning::BsDependencies => {
473+
log_deprecated_config_field(&package.name, "bs-dependencies", "dependencies");
474+
}
475+
config::DeprecationWarning::BsDevDependencies => {
476+
log_deprecated_config_field(&package.name, "bs-dev-dependencies", "dev-dependencies");
477+
}
478+
config::DeprecationWarning::BscFlags => {
479+
log_deprecated_config_field(&package.name, "bsc-flags", "compiler-flags");
480+
}
481+
},
482+
);
483+
}
483484
});
484485
}
485486

0 commit comments

Comments
 (0)