Map properties via static config

This allows us to rename values fetched from the API semi-automatically.

Author: erbridge

lib/Model.js

@@ -4,27 +4,36 @@ import ReplicateObject from "./ReplicateObject.js";
 import { sleep } from "./utils.js";
 
 export default class Model extends ReplicateObject {
-  constructor({ owner, name, version, id, ...rest }, client) {
+  static propertyMap = {
+    id: "version",
+  };
+
+  constructor({ owner, name, version, ...rest }, client) {
     super(rest, client);
 
-    if (!owner) {
+    if (owner) {
+      this.owner = owner;
+    }
+
+    if (!this.owner) {
       throw new ReplicateError("owner is required");
     }
 
-    this.owner = owner;
+    if (name) {
+      this.name = name;
+    }
 
-    if (!name) {
+    if (!this.name) {
       throw new ReplicateError("name is required");
     }
 
-    this.name = name;
+    if (version) {
+      this.version = version;
+    }
 
-    if (!(version || id)) {
+    if (!this.version) {
       throw new ReplicateError("version is required");
     }
-
-    // We get `id` back from the API, but we want to call it `version` here.
-    this.version = version || id;
   }
 
   actionForGet() {

lib/Model.test.js

@@ -22,6 +22,19 @@ beforeEach(() => {
   model = client.model("test-owner/test-name@testversion");
 });
 
+describe("constructor()", () => {
+  it("maps id to version", () => {
+    const model = new Model({
+      owner: "test-owner",
+      name: "test-name",
+      id: "testversion",
+    });
+
+    expect(model.id).toBeUndefined();
+    expect(model.version).toBe("testversion");
+  });
+});
+
 describe("load()", () => {
   it("makes request to get model version", async () => {
     jest.spyOn(client, "request").mockResolvedValue({

lib/Prediction.js

@@ -13,11 +13,13 @@ export default class Prediction extends ReplicateObject {
   constructor({ id, ...rest }, client) {
     super(rest, client);
 
-    if (!id) {
-      throw new ReplicateError("id is required");
+    if (id) {
+      this.id = id;
     }
 
-    this.id = id;
+    if (!this.id) {
+      throw new ReplicateError("id is required");
+    }
   }
 
   actionForGet() {

lib/ReplicateObject.js

@@ -1,6 +1,8 @@
 import { ReplicateError } from "./errors.js";
 
 export default class ReplicateObject {
+  static propertyMap = {};
+
   static fromJSON(json) {
     let props;
     try {
@@ -15,20 +17,15 @@ export default class ReplicateObject {
   client;
 
   constructor(props, client) {
-    for (const key in props) {
-      this[key] = props[key];
-    }
-
+    this.#setProps(props);
     this.client = client;
   }
 
   async load() {
     const action = this.actionForGet();
     const props = await this.client.request(action);
 
-    for (const key in props) {
-      this[key] = props[key];
-    }
+    this.#setProps(props);
 
     return this;
   }
@@ -40,4 +37,10 @@ export default class ReplicateObject {
   actionForGet() {
     throw new ReplicateError("Not implemented");
   }
+
+  #setProps(props) {
+    for (const key in props) {
+      this[this.constructor.propertyMap[key] || key] = props[key];
+    }
+  }
 }