Skip to content

Commit c77125a

Browse files
authored
Fix CI for Node 20.x (#239)
* Update to actions/checkout@v4 * Use actions/setup-node@v4 * Add missing node-version value to integration-browser * npm i --save-dev nock@beta * Pin to Node.js 20.11.1
1 parent 19a5ca9 commit c77125a

File tree

3 files changed

+19
-18
lines changed

3 files changed

+19
-18
lines changed

.github/workflows/ci.yml

+14-12
Original file line numberDiff line numberDiff line change
@@ -13,12 +13,13 @@ jobs:
1313
strategy:
1414
matrix:
1515
# See supported Node.js release schedule at https://nodejs.org/en/about/previous-releases
16-
node-version: [18.x, 20.x]
16+
# FIXME: Tests are failing on Node.js v20.12.1 (https://github.com/replicate/replicate-javascript/issues/237)
17+
node-version: [18.x, 20.11.1]
1718

1819
steps:
19-
- uses: actions/checkout@v3
20+
- uses: actions/checkout@v4
2021
- name: Use Node.js ${{ matrix.node-version }}
21-
uses: actions/setup-node@v3
22+
uses: actions/setup-node@v4
2223
with:
2324
node-version: ${{ matrix.node-version }}
2425
cache: "npm"
@@ -36,9 +37,9 @@ jobs:
3637
tarball-name: ${{ steps.pack.outputs.tarball-name }}
3738

3839
steps:
39-
- uses: actions/checkout@v3
40+
- uses: actions/checkout@v4
4041
- name: Use Node.js
41-
uses: actions/setup-node@v3
42+
uses: actions/setup-node@v4
4243
with:
4344
node-version: 20.x
4445
cache: "npm"
@@ -67,12 +68,12 @@ jobs:
6768
fail-fast: false
6869

6970
steps:
70-
- uses: actions/checkout@v3
71+
- uses: actions/checkout@v4
7172
- uses: actions/download-artifact@v3
7273
with:
7374
name: package-tarball
7475
- name: Use Node.js ${{ matrix.node-version }}
75-
uses: actions/setup-node@v3
76+
uses: actions/setup-node@v4
7677
with:
7778
node-version: ${{ matrix.node-version }}
7879
cache: "npm"
@@ -90,17 +91,18 @@ jobs:
9091

9192
strategy:
9293
matrix:
94+
node-version: [20.x]
9395
browser: ["chromium", "firefox", "webkit"]
9496
suite: ["browser"]
9597
fail-fast: false
9698

9799
steps:
98-
- uses: actions/checkout@v3
100+
- uses: actions/checkout@v4
99101
- uses: actions/download-artifact@v3
100102
with:
101103
name: package-tarball
102104
- name: Use Node.js ${{ matrix.node-version }}
103-
uses: actions/setup-node@v3
105+
uses: actions/setup-node@v4
104106
with:
105107
node-version: ${{ matrix.node-version }}
106108
cache: "npm"
@@ -125,12 +127,12 @@ jobs:
125127
suite: [cloudflare-worker]
126128

127129
steps:
128-
- uses: actions/checkout@v3
130+
- uses: actions/checkout@v4
129131
- uses: actions/download-artifact@v3
130132
with:
131133
name: package-tarball
132134
- name: Use Node.js ${{ matrix.node-version }}
133-
uses: actions/setup-node@v3
135+
uses: actions/setup-node@v4
134136
with:
135137
node-version: ${{ matrix.node-version }}
136138
cache: "npm"
@@ -154,7 +156,7 @@ jobs:
154156
suite: [bun]
155157

156158
steps:
157-
- uses: actions/checkout@v3
159+
- uses: actions/checkout@v4
158160
- uses: actions/download-artifact@v3
159161
with:
160162
name: package-tarball

package-lock.json

+4-5
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@
4242
"@typescript-eslint/eslint-plugin": "^5.56.0",
4343
"cross-fetch": "^3.1.5",
4444
"jest": "^29.6.2",
45-
"nock": "^14.0.0-beta.4",
45+
"nock": "^14.0.0-beta.5",
4646
"publint": "^0.2.7",
4747
"ts-jest": "^29.1.0",
4848
"typescript": "^5.0.2"

0 commit comments

Comments
 (0)