Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public repo can't find private config in our GitHub org anymore #7238

Closed
mortenlocka opened this issue Sep 10, 2020 · 2 comments
Closed

Public repo can't find private config in our GitHub org anymore #7238

mortenlocka opened this issue Sep 10, 2020 · 2 comments

Comments

@mortenlocka
Copy link

mortenlocka commented Sep 10, 2020

What Renovate type, platform and version are you using?

Github, hosted app, free version

Describe the bug

We have a common config in a private repository in our GitHub organisation. Suddenly our public repositories can't access the private config anymore. This started about a month ago. All of the repositories are in the renovatebot repository access list.
Our private repositories still work fine.

Relevant debug logs
DEBUG: Preset fetch error
{
"preset": "github>entur/abt-renovate-config",
"err": {
"message": "dep not found",
"stack": "Error: dep not found\n at fetchJSONFile (/home/ubuntu/renovateapp/node_modules/renovate/dist/config/presets/github/index.js:22:15)\n at runMicrotasks ()\n at processTicksAndRejections (internal/process/task_queues.js:97:5)"
}
}
INFO: Throwing preset error
{
"validationError": "Cannot find preset's package (github>entur/abt-renovate-config)"
}
INFO: Repository has invalid config
{
"error": {
"validationError": "Cannot find preset's package (github>entur/abt-renovate-config)"
}
}
To Reproduce

entur/schema2proto#61

@rarkins
Copy link
Collaborator

rarkins commented Sep 10, 2020

This is part of some enhanced app security we adopted that wasn't originally available from GitHub. A GitHub app can request tokens for either (a) the entire account, or (b) a specific repo only. When a repo is private, we request it for the entire account, allowing private repos to depend on other private repos, but when a repo is public then we request it for just that repo. The reasoning is that if a token leakage occurs by accident on a public repo then at least it won't expose private repositories.

If people want to be "less secure" by opt-in then we can consider that, but I'm curious what is the reason for your config being private. Does it contain secrets, for example?

@mortenlocka
Copy link
Author

Thanks for a quick answer! Yeah, contains some encrypted secrets. We might split it up, and create a public config without any information about our private urls etc.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants