Skip to content

Commit 0974c19

Browse files
authored
Merge pull request #149 from tigranmaestro/master
Make Some Properties Not Required
2 parents 92940f3 + de3d237 commit 0974c19

File tree

2 files changed

+19
-13
lines changed

2 files changed

+19
-13
lines changed

src/ProjectData/Screen/Area/Entity/TextArea.php

Lines changed: 16 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,6 @@ class TextArea extends AbstractArea
1616
self::KEY_CORDS,
1717
self::KEY_HEIGHT,
1818
self::KEY_WIDTH,
19-
self::KEY_ORIGINAL_HEIGHT,
20-
self::KEY_ORIGINAL_WIDTH,
2119
self::KEY_ORDER,
2220
self::KEY_WORD_COUNT,
2321
self::KEY_TITLE,
@@ -27,10 +25,10 @@ class TextArea extends AbstractArea
2725
/** @var string */
2826
protected $type = self::AREA_TYPE_TEXT;
2927

30-
/** @var int */
28+
/** @var int|null */
3129
protected $originalHeight;
3230

33-
/** @var int */
31+
/** @var int|null */
3432
protected $originalWidth;
3533

3634
/** @var bool|null */
@@ -160,11 +158,13 @@ public function exchangeArray(array $textAreaArrayData)
160158
}
161159
}
162160

163-
$originalHeight = $textAreaArrayData[self::KEY_ORIGINAL_HEIGHT];
164-
$this->setOriginalHeight($originalHeight);
161+
if (array_key_exists(self::KEY_ORIGINAL_HEIGHT, $textAreaArrayData)) {
162+
$this->setOriginalHeight($textAreaArrayData[self::KEY_ORIGINAL_HEIGHT]);
163+
}
165164

166-
$originalWidth = $textAreaArrayData[self::KEY_ORIGINAL_WIDTH];
167-
$this->setOriginalWidth($originalWidth);
165+
if (array_key_exists(self::KEY_ORIGINAL_WIDTH, $textAreaArrayData)) {
166+
$this->setOriginalWidth($textAreaArrayData[self::KEY_ORIGINAL_WIDTH]);
167+
}
168168

169169
if (array_key_exists(self::KEY_REMOVED, $textAreaArrayData)) {
170170
$this->setRemoved($textAreaArrayData[self::KEY_REMOVED]);
@@ -188,10 +188,16 @@ public function getArrayCopy(): array
188188
{
189189
$arrayCopy = [
190190
self::KEY_TYPE => self::AREA_TYPE_TEXT,
191-
self::KEY_ORIGINAL_HEIGHT => $this->getOriginalHeight(),
192-
self::KEY_ORIGINAL_WIDTH => $this->getOriginalWidth(),
193191
];
194192

193+
if (false === is_null($this->getOriginalHeight())) {
194+
$arrayCopy[self::KEY_ORIGINAL_HEIGHT] = $this->getOriginalHeight();
195+
}
196+
197+
if (false === is_null($this->getOriginalWidth())) {
198+
$arrayCopy[self::KEY_ORIGINAL_WIDTH] = $this->getOriginalWidth();
199+
}
200+
195201
if (false === is_null($this->getRemoved())) {
196202
$arrayCopy[self::KEY_REMOVED] = $this->getRemoved();
197203
}

src/ProjectData/Screen/Entity/Screen.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -698,13 +698,13 @@ public function exchangeArray(array $screenArrayData)
698698
$screenDuration = $screenArrayData[self::KEY_DURATION];
699699
$this->duration = $screenDuration;
700700

701-
$screenSelectedDuration = $screenArrayData[self::KEY_SELECTED_DURATION];
702-
$this->selectedDuration = $screenSelectedDuration;
701+
if (array_key_exists(self::KEY_SELECTED_DURATION, $screenArrayData)) {
702+
$this->selectedDuration = $screenArrayData[self::KEY_SELECTED_DURATION];
703+
}
703704

704705
$screenExtraVideoSecond = $screenArrayData[self::KEY_EXTRA_VIDEO_SECOND];
705706
$this->setExtraVideoSecond($screenExtraVideoSecond);
706707

707-
708708
if (array_key_exists(self::KEY_GIF_BIG_PATH, $screenArrayData)) {
709709
$this->setGifBigPath($screenArrayData[self::KEY_GIF_BIG_PATH]);
710710
}

0 commit comments

Comments
 (0)