Open
Conversation
reneemeyer
suggested changes
Aug 10, 2017
reneemeyer
left a comment
reneemeyer
left a comment
There was a problem hiding this comment.
Renata, good job on your JS methodology, I can kind of see where you're coming from, however I would like to see some more comments in your code, with these types of functions other developers are going to need a road map to understand what's going on. Please put in at least 5 comments describing your code and turn bubbleSort into a recursive function. Thanks!
| var temp = arr[j-1]; | ||
| arr[j-1] = arr[j]; | ||
| arr[j] = temp; | ||
| } |
There was a problem hiding this comment.
Renata, I see where your going here, however, I would like for you to avoid using two loops and use a recursive function instead.
| right =arr.slice(mid); | ||
| //send left and right to the mergeSort to broke it down into pieces | ||
| //then merge those | ||
| return merge(mergeSort(left),mergeSort(right)); |
| function mergeSort(arr) { | ||
| // Your code here | ||
| function merge(left, right){ | ||
| var result = [], |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checkpoint Rubric
This is the rubric that your instructor will use to grade your checkpoints. Please do not edit.
Checkpoint 1
Checkpoint 2
Checkpoint 3