-
Notifications
You must be signed in to change notification settings - Fork 91
Remove package.json and deno.lock from Deno template #134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Depends on remix-run/react-router#13744 |
this probably solves #132 |
It will! Just waiting for an official release with the fix in order to open this PR. |
@brookslybrand I think this is ready to be merged now |
Looks like the CLI also looks for a
|
@brookslybrand so, this one is trickier… for (let dependency in dependencies) {
let version = dependencies[dependency];
if (
(dependency.startsWith("@react-router/") ||
dependency === "react-router" ||
dependency === "react-router-dom") &&
version === "*"
) {
dependencies[dependency] = semver.prerelease(ctx.reactRouterVersion)
? // Templates created from prereleases should pin to a specific version
ctx.reactRouterVersion
: "^" + ctx.reactRouterVersion;
}
} Should I add support for checking |
Unfortunately, that PR did not fix it. ![]() I can dive deeper and try to fix it. Do you have thoughts on the approach, re: my previous message @brookslybrand? Also, should we go ahead and merge this anyway since the current template fails also and it's not a regression of functionality? |
That's annoying/weird. I haven't really looked into it enough to know what needs to be changed to fixed this. Basically whatever in the CLI that is checking for The current template works right now because it has a package.json. I'd prefer not to merge this one in because it will make it to where
fails completely |
No description provided.