-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial flag does not take into account lazy loading #400
Comments
@skovhus thanks for checking and for opening the issue! rollup doesn't provide the In the meantime, if you need to fix the data for specific chunks, you can use the |
Yeah we are already using the transform to traverse our tree of dependencies and correct all |
@skovhus, we are testing a fix on Let me know how it goes if you get the chance to try it. If you notice any issues, it would be very helpful if you could share the rollup stats JSON file( |
The changes are now available on v2.0.0-beta.6, currently testing it with couple larger projects. Please let us know how it looks if you manage to try it. |
Changes available on |
Thanks! We ended up with a custom implementation, but I'll have a look at this next time we touch this. |
Great! Let us know how it goes when you get the chance to update it ;) |
Currently the plugin detects if a chunk is initial based on the
[isDynamicEntry
information from rollup](https://github.com/relative-ci/rollup-plugin-webpack-stats/blob/master/src/transform.ts#L140). This is a pretty broken heuristic as a chunk might be synchronously imported by a chunk that is dynamic.Example
A (initial) lazy loads B that synchronously loads C.
Expected: C should not be marked
initial
Currently: C is marked as
initial
The text was updated successfully, but these errors were encountered: