Skip to content

Commit 625eae9

Browse files
Fix report template test fixtures to supply resolved URLs and expect encoded dollar signs
<!-- coderabbit-ai-generated:v1 -->
1 parent 035c36f commit 625eae9

2 files changed

Lines changed: 12 additions & 1 deletion

File tree

‎report/src/test/java/org/hjug/refactorfirst/report/InteractiveTemplateTest.java‎

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ void rendersPackageClassRelationshipsOnSeparateLinesWithHyperlinks() throws Exce
130130
html));
131131
assertTrue(
132132
html.contains(
133-
"href=\"https://github.com/test/test/blob/src/main/java/com/example/EnhancedParameterComputer$EnhancedParameters.java\""),
133+
"href=\"https://github.com/test/test/blob/src/main/java/com/example/EnhancedParameterComputer%24EnhancedParameters.java\""),
134134
html);
135135
assertTrue(html.contains("EnhancedParameterComputer$EnhancedParameters"), html);
136136
}
@@ -139,6 +139,11 @@ private Map<String, Object> classRelationship(String source, String target, int
139139
Map<String, Object> relationship = new LinkedHashMap<>();
140140
relationship.put("sourceClassPath", "src/main/java/com/example/" + source + ".java");
141141
relationship.put("targetClassPath", "src/main/java/com/example/" + target + ".java");
142+
relationship.put(
143+
"sourceClassUrl", "https://github.com/test/test/blob/src/main/java/com/example/" + source + ".java");
144+
relationship.put(
145+
"targetClassUrl",
146+
"https://github.com/test/test/blob/src/main/java/com/example/" + target.replace("$", "%24") + ".java");
142147
relationship.put("simpleSourceClassName", source);
143148
relationship.put("simpleTargetClassName", target);
144149
relationship.put("weight", weight);

‎report/src/test/java/org/hjug/refactorfirst/report/SimpleHtmlReportTemplateTest.java‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -268,7 +268,9 @@ private Map<String, Object> classRelationshipsToRemove() {
268268
row.put("sourceClass", "com.example.A");
269269
row.put("targetClass", "com.example.B");
270270
row.put("sourceClassPath", "src/main/java/com/example/A.java");
271+
row.put("sourceClassUrl", "https://github.com/test/test/blob/src/main/java/com/example/A.java");
271272
row.put("targetClassPath", "src/main/java/com/example/B.java");
273+
row.put("targetClassUrl", "https://github.com/test/test/blob/src/main/java/com/example/B.java");
272274
row.put("simpleSourceClassName", "A");
273275
row.put("simpleTargetClassName", "B");
274276
row.put("sourceMarked", true);
@@ -311,7 +313,9 @@ private Map<String, Object> packageRelationshipsToRemove() {
311313
private Map<String, Object> packageRelationshipsToRemoveWithLinks() {
312314
Map<String, Object> classRelationship = new LinkedHashMap<>();
313315
classRelationship.put("sourceClassPath", "src/main/java/com/example/A.java");
316+
classRelationship.put("sourceClassUrl", "https://github.com/test/test/blob/src/main/java/com/example/A.java");
314317
classRelationship.put("targetClassPath", "src/main/java/com/example/B.java");
318+
classRelationship.put("targetClassUrl", "https://github.com/test/test/blob/src/main/java/com/example/B.java");
315319
classRelationship.put("simpleSourceClassName", "A");
316320
classRelationship.put("simpleTargetClassName", "B");
317321
classRelationship.put("weight", 5);
@@ -320,7 +324,9 @@ private Map<String, Object> packageRelationshipsToRemoveWithLinks() {
320324
packageRelationship.put("sourcePackage", "com.example");
321325
packageRelationship.put("targetPackage", "com.other");
322326
packageRelationship.put("sourcePackagePath", "src/main/java/com/example");
327+
packageRelationship.put("sourcePackageUrl", "https://github.com/test/test/blob/src/main/java/com/example");
323328
packageRelationship.put("targetPackagePath", "src/main/java/com/other");
329+
packageRelationship.put("targetPackageUrl", "https://github.com/test/test/blob/src/main/java/com/other");
324330
packageRelationship.put("sourceMarked", true);
325331
packageRelationship.put("targetMarked", false);
326332
packageRelationship.put("weight", 7);

0 commit comments

Comments
 (0)