Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PWM Offset wrapping after midnight #247

Open
lnevo opened this issue Nov 25, 2018 · 0 comments
Open

PWM Offset wrapping after midnight #247

lnevo opened this issue Nov 25, 2018 · 0 comments

Comments

@lnevo
Copy link
Contributor

lnevo commented Nov 25, 2018

Same issue as was fixed in the SunLocation code #246

If you have a time crossing midnight and the Pre/Post offsets are applied and they take the value below zero it will screw up the values.

Solution will be to convert to a real time value and then convert back to minutes. There's probably an easier way then what I've done :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant