Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TimedPort issue with Repeat variable #222

Open
lnevo opened this issue Oct 10, 2015 · 0 comments
Open

TimedPort issue with Repeat variable #222

lnevo opened this issue Oct 10, 2015 · 0 comments

Comments

@lnevo
Copy link
Contributor

lnevo commented Oct 10, 2015

Currently, I'm using Repeat and Time to calculate an onTime and offTime and using that in the Osc function intended to be compatible with the Apex usage. However, I'm calculating the offTime by subtracting onTime from Repeat. This could cause issues if Repeat is set to 0 with the intent to disable any repeat. I'll need to add some sanity checks to ensure this does not happen.
lnevo added a commit to lnevo/Libraries that referenced this issue Oct 10, 2015
@lnevo
Fixed issue reefangel#222 - Repeat of 0 or less than Time could have …
082f031 
…caused issues.

Added additional comments to make it clearer how to use the class
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lnevo