Merge pull request #1321 from dzhiriki/feature/patch-1

replaceReducer() should throw if argument is not a function

Author: gaearon

src/createStore.js

@@ -159,6 +159,10 @@ export default function createStore(reducer, initialState, enhancer) {
    * @returns {void}
    */
   function replaceReducer(nextReducer) {
+    if (typeof nextReducer !== 'function') {
+      throw new Error('Expected the nextReducer to be a function.')
+    }
+
     currentReducer = nextReducer
     dispatch({ type: ActionTypes.INIT })
   }

test/createStore.spec.js

@@ -536,4 +536,16 @@ describe('createStore', () => {
       createStore(reducers.todos, {})
     ).toNotThrow()
   })
+
+  it('throws if nextReducer is not a function', () => {
+    const store = createStore(reducers.todos)
+
+    expect(() =>
+      store.replaceReducer()
+    ).toThrow('Expected the nextReducer to be a function.')
+
+    expect(() =>
+      store.replaceReducer(() => {})
+    ).toNotThrow()
+  })
 })