Bugfix: Prevent double-prefixing when using combineActions (#334)

* Bugfix: Prevent double-prefixing when using `combineActions`

* remove focus from test

Author: SuaYoo

src/utils/flattenWhenNode.js

@@ -19,7 +19,11 @@ export default predicate =>
     }
 
     function connectPrefix(type) {
-      if (partialFlatActionType || !prefix) {
+      if (
+        partialFlatActionType ||
+        !prefix ||
+        (prefix && new RegExp(`^${prefix}${namespace}`).test(type))
+      ) {
         return type;
       }
 

test/combineActions.test.js

@@ -32,6 +32,26 @@ test('returns a stringifiable object', () => {
   );
 });
 
+test('handles prefixed action types', () => {
+  const options = { prefix: 'my-custom-prefix' };
+  const { action1, action2 } = createActions('ACTION_1', 'ACTION_2', options);
+
+  expect(
+    combineActions(
+      'my-custom-prefix/ACTION_1',
+      'my-custom-prefix/ACTION_2'
+    ).toString()
+  ).toBe('my-custom-prefix/ACTION_1||my-custom-prefix/ACTION_2');
+  expect(combineActions(action1, action2).toString()).toBe(
+    'my-custom-prefix/ACTION_1||my-custom-prefix/ACTION_2'
+  );
+  expect(
+    combineActions(action1, action2, 'my-custom-prefix/ACTION_3').toString()
+  ).toBe(
+    'my-custom-prefix/ACTION_1||my-custom-prefix/ACTION_2||my-custom-prefix/ACTION_3'
+  );
+});
+
 test('should throw error if actions is empty', () => {
   expect(() => combineActions()).toThrow(
     'Expected action types to be strings, symbols, or action creators'

test/handleActions.test.js

@@ -556,3 +556,36 @@ test('works with combineActions nested', () => {
     loading: true
   });
 });
+
+test('works with a prefix and namespace', () => {
+  const { increment, decrement } = createActions(
+    {
+      INCREMENT: [amount => ({ amount }), amount => ({ key: 'value', amount })],
+      DECREMENT: amount => ({ amount: -amount })
+    },
+    { prefix: 'my-custom-prefix', namespace: '--' }
+  );
+
+  // NOTE: We should be using combineReducers in production, but this is just a test.
+  const reducer = handleActions(
+    {
+      [combineActions(increment, decrement)]: (
+        { counter },
+        { payload: { amount } }
+      ) => ({
+        counter: counter + amount
+      })
+    },
+    { counter: 0 },
+    { prefix: 'my-custom-prefix', namespace: '--' }
+  );
+
+  expect(String(increment)).toBe('my-custom-prefix--INCREMENT');
+
+  expect(reducer({ counter: 3 }, increment(2))).toEqual({
+    counter: 5
+  });
+  expect(reducer({ counter: 10 }, decrement(3))).toEqual({
+    counter: 7
+  });
+});