Skip to content

AIO support in RediSearch module? #2053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alancleary opened this issue Mar 16, 2022 · 3 comments
Closed

AIO support in RediSearch module? #2053

alancleary opened this issue Mar 16, 2022 · 3 comments
Assignees

Comments

@alancleary
Copy link

I opened an issue in the redisearch-py repo a while back (RediSearch/redisearch-py#92) asking if they had any plans to add support for aioredis. Since then redisearch-py has been merged with redis-py and I see now that the imminent 4.2.0 will also merge the aioredis-py library. I'm wondering if the 4.2.0 release will add aioredis support to the redisearch module and, if not, if there's a timeline for this. If there's no timeline but you're open to this feature then I'd be happy to tackle the initial implementation and make a PR (my original issue links to an implementation I made in August of 2021 that has been languishing ever since).

Thanks for providing this awesome library. I'm glad to see all the redis libraries I use being merged into one 😃

@chayim
Copy link
Contributor

chayim commented Mar 22, 2022

@alancleary First off - those are mighty kind words! Looking at client.py, we've merged it in - but honestly we don't have currently have this under test. From my standpoint that means it doesn't work - until we have proof!

@dvora-h can you take a look?

@chayim
Copy link
Contributor

chayim commented May 29, 2022

@alancleary As of now (redis-py >= 4.3.1) we have aioredis as part of the library. I think we can safely close this.

@chayim chayim closed this as completed May 29, 2022
@alancleary
Copy link
Author

This is great news! Thanks for adding the feature :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants