[CAE-686] Minor pushTuples change, renamed HSETEX test

htemelski-oss · htemelski-oss · commit 4d354fe3e001 · 2025-03-12T12:25:52.000+02:00
diff --git a/packages/client/lib/commands/HSETEX.spec.ts b/packages/client/lib/commands/HSETEX.spec.ts
@@ -70,7 +70,7 @@ describe('HSETEX parseCommand', () => {
 
 // TODO: enable when new test container is released
 describe.skip('HSETEX call', () => {
-    testUtils.testWithClientIfVersionWithinRange([[8], 'LATEST'], 'hSetEx empty single field', async client => {
+    testUtils.testWithClientIfVersionWithinRange([[8], 'LATEST'], 'hSetEx calls', async client => {
       assert.deepEqual(
         await client.hSetEx('key', {expiration: {type: "EX", value: 500}, mode: "FNX"}, 'filed1', 'value1'),
         1
diff --git a/packages/client/lib/commands/HSETEX.ts b/packages/client/lib/commands/HSETEX.ts
@@ -89,9 +89,7 @@ function pushTuples(parser: CommandParser, tuples: HSETEXTuples): void {
     }
 
     parser.push((tmpParser.redisArgs.length/2).toString())
-    tmpParser.redisArgs.forEach(arg => {
-        parser.push(arg)
-    });
+    parser.push(...tmpParser.redisArgs)
 }
 
 function _pushTuples(parser: CommandParser, tuples: HSETEXTuples): void {

Original file line number	Diff line number	Diff line change
`@@ -70,7 +70,7 @@ describe('HSETEX parseCommand', () => {`
`70`	`70`
`71`	`71`	`// TODO: enable when new test container is released`
`72`	`72`	`describe.skip('HSETEX call', () => {`
`73`		`- testUtils.testWithClientIfVersionWithinRange([[8], 'LATEST'], 'hSetEx empty single field', async client => {`
	`73`	`+ testUtils.testWithClientIfVersionWithinRange([[8], 'LATEST'], 'hSetEx calls', async client => {`
`74`	`74`	`assert.deepEqual(`
`75`	`75`	`await client.hSetEx('key', {expiration: {type: "EX", value: 500}, mode: "FNX"}, 'filed1', 'value1'),`
`76`	`76`	`1`
Original file line number	Diff line number	Diff line change
`@@ -89,9 +89,7 @@ function pushTuples(parser: CommandParser, tuples: HSETEXTuples): void {`
`89`	`89`	`}`
`90`	`90`
`91`	`91`	`parser.push((tmpParser.redisArgs.length/2).toString())`
`92`		`- tmpParser.redisArgs.forEach(arg => {`
`93`		`- parser.push(arg)`
`94`		`- });`
	`92`	`+ parser.push(...tmpParser.redisArgs)`
`95`	`93`	`}`
`96`	`94`
`97`	`95`	`function _pushTuples(parser: CommandParser, tuples: HSETEXTuples): void {`