Skip to content

support vector set #3367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
fukua95 opened this issue May 6, 2025 · 3 comments · May be fixed by #3375
Open

support vector set #3367

fukua95 opened this issue May 6, 2025 · 3 comments · May be fixed by #3375

Comments

@fukua95
Copy link
Contributor

fukua95 commented May 6, 2025

Hi @ndyakov , Redis 8.0 implemented Vector Set. Have you started the work to support Vector Set in go-redis? If you haven't had time to do it yet, I'd be happy to implement this feature and follow up with potential changes before Vector Set stabilizes.
@ndyakov
Copy link
Member

ndyakov commented May 6, 2025

Hello @fukua95! I haven't started, feel free to contribute and I will help you with reviewing the PR and adding additional tests.

@fukua95
Copy link
Contributor Author

fukua95 commented May 9, 2025

Hello @fukua95! I haven't started, feel free to contribute and I will help you with reviewing the PR and adding additional tests.

Hello @ndyakov , I've implemented this feature and would appreciate your review of the PR when you have time. Thank you!

@ofekshenawa ofekshenawa linked a pull request May 11, 2025 that will close this issue
feat: support vectorset #3375
Open
@ndyakov
Copy link
Member

ndyakov commented May 15, 2025

@fukua95 just to set expectations, the review should be sometime next week since we are discussing the proper responses for those vector commands. If anything different is decided I will leave it as a comment on the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: support vectorset fukua95/go-redis
2 participants
@ndyakov @fukua95