perf: prevent needless allocation for string (#423)

supercaracal · web-flow · commit 4d0656aa4487 · 2025-01-01T07:56:53.000+09:00
diff --git a/lib/redis_client/cluster/command.rb b/lib/redis_client/cluster/command.rb
@@ -123,7 +123,7 @@ def determine_first_key_position(command) # rubocop:disable Metrics/CyclomaticCo
 
       def determine_optional_key_position(command, option_name)
         command.each_with_index do |e, i|
-          return i + 1 if e.to_s.downcase(:ascii) == option_name
+          return i + 1 if e.to_s.casecmp(option_name).zero?
         end
 
         0

Original file line number	Diff line number	Diff line change
`@@ -123,7 +123,7 @@ def determine_first_key_position(command) # rubocop:disable Metrics/CyclomaticCo`
`123`	`123`
`124`	`124`	`def determine_optional_key_position(command, option_name)`
`125`	`125`	`command.each_with_index do \|e, i\|`
`126`		`- return i + 1 if e.to_s.downcase(:ascii) == option_name`
	`126`	`+ return i + 1 if e.to_s.casecmp(option_name).zero?`
`127`	`127`	`end`
`128`	`128`
`129`	`129`	`0`