Skip to content

Commit 4ecfc05

Browse files
Updated project description and fixed benchmark config utilities (#39)
1 parent f1360e9 commit 4ecfc05

File tree

4 files changed

+17
-27
lines changed

4 files changed

+17
-27
lines changed

README.md

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,19 +5,20 @@
55
# redisbench-admin
66

77
Redis benchmark run helper can help you with the following tasks:
8-
8+
- Setup abd teardown of benchmarking infrastructure specified on [RedisLabsModules/testing-infrastructure](https://github.com/RedisLabsModules/testing-infrastructure)
99
- Setup and teardown of an Redis and Redis Modules DBs for benchmarking
1010
- Management of benchmark data and specifications across different setups
1111
- Running benchmarks and recording results
12-
- Comparing performance results
1312
- Exporting performance results in several formats (CSV, RedisTimeSeries, JSON)
13+
- [SOON] Comparing performance results
1414
- [SOON] Finding performance problems by attaching telemetry probes
1515

1616
Current supported benchmark tools:
17-
- [redisgraph-database-benchmark](https://github.com/RedisGraph/graph-database-benchmark/tree/master/benchmark/redisgraph)
17+
- [redisgraph-benchmark-go](https://github.com/RedisGraph/redisgraph-benchmark-go)
1818
- [ftsb_redisearch](https://github.com/RediSearch/ftsb)
19-
20-
** future versions will also support redis-benchmark and memtier_benchmark.
19+
- [redis-benchmark](https://github.com/redis/redis)
20+
- [SOON][memtier_benchmark](https://github.com/RedisLabs/memtier_benchmark)
21+
- [SOON][aibench](https://github.com/RedisAI/aibench)
2122

2223
## Installation
2324

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[tool.poetry]
22
name = "redisbench-admin"
3-
version = "0.1.38"
3+
version = "0.1.39"
44
description = "Redis benchmark run helper. A wrapper around Redis and Redis Modules benchmark tools ( ftsb_redisearch, memtier_benchmark, redis-benchmark, aibench, etc... )."
55
authors = ["filipecosta90 <[email protected]>"]
66
readme = "README.md"
Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,28 +1,17 @@
11
from jsonpath_ng import parse
22

33

4-
<<<<<<< HEAD
54
def parseExporterMetricsDefinition(
65
benchmark_config: dict, configkey: str = "redistimeseries"
76
):
87
metrics = []
98
if configkey in benchmark_config:
109
if "metrics" in benchmark_config[configkey]:
1110
for metric_name in benchmark_config[configkey]["metrics"]:
12-
=======
13-
def parseExporterMetricsDefinition(benchmark_config, configkey="redistimeseries"):
14-
metrics = []
15-
if configkey in benchmark_config:
16-
if "metrics" in benchmark_config[configkey]:
17-
for metric_name in benchmark_config[configkey][
18-
"metrics"
19-
]:
20-
>>>>>>> origin/master
2111
metrics.append(metric_name)
2212
return metrics
2313

2414

25-
<<<<<<< HEAD
2615
def parseExporterTimeMetricDefinition(
2716
benchmark_config: dict, configkey: str = "redistimeseries"
2817
):
@@ -35,14 +24,4 @@ def parseExporterTimeMetricDefinition(
3524
def parseExporterTimeMetric(metricPath: str, results_dict: dict):
3625
jsonpath_expr = parse(metricPath)
3726
datapoints_timestamp = int(jsonpath_expr.find(results_dict)[0].value)
38-
=======
39-
def parseExporterTimeMetric(benchmark_config, results_dict, configkey="redistimeseries"):
40-
datapoints_timestamp = None
41-
if "timemetric" in benchmark_config[configkey]:
42-
tspath = benchmark_config[configkey]["timemetric"]
43-
jsonpath_expr = parse(tspath)
44-
datapoints_timestamp = int(
45-
jsonpath_expr.find(results_dict)[0].value
46-
)
47-
>>>>>>> origin/master
4827
return datapoints_timestamp

tests/test_utils.py

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,16 @@
44

55

66
class Test(TestCase):
7+
def test_benchmark_config_parseExporterMetricsDefinition(self):
8+
benchmark_config = {}
9+
pass
10+
11+
def test_benchmark_config_parseExporterTimeMetricDefinition(self):
12+
pass
13+
14+
def test_benchmark_config_parseExporterTimeMetric(self):
15+
pass
16+
717
def test_retrieve_local_or_remote_input_json(self):
818
benchmark_config = retrieve_local_or_remote_input_json(
919
"./tests/test_data/redis-benchmark.6.2.results.csv",

0 commit comments

Comments
 (0)