Skip to content

Commit 911f147

Browse files
authored
Merge pull request ComplianceAsCode#4394 from ggbecker/remove-ed25519-keytype-from-dockerfiles
Remove ed25519 key generation from Dockerfiles as it is not supported when FIPS is enabled.
2 parents 4858592 + f798ae3 commit 911f147

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

Dockerfiles/test_suite-centos

+2-2
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ ENV AUTH_KEYS=/root/.ssh/authorized_keys
66
ARG CLIENT_PUBLIC_KEY
77
ARG ADDITIONAL_PACKAGES
88

9-
# Insall Python so Ansible remediations can work
9+
# Install Python so Ansible remediations can work
1010
# Don't clean all, as the test scenario may require package install.
1111
RUN true \
1212
&& yum install -y openssh-clients openssh-server openscap-scanner \
@@ -15,7 +15,7 @@ RUN true \
1515
&& true
1616

1717
RUN true \
18-
&& for key_type in rsa ecdsa ed25519; do ssh-keygen -N '' -t $key_type -f /etc/ssh/ssh_host_${key_type}_key; done \
18+
&& for key_type in rsa ecdsa; do ssh-keygen -N '' -t $key_type -f /etc/ssh/ssh_host_${key_type}_key; done \
1919
&& mkdir -p /root/.ssh \
2020
&& printf "%s\n" "$CLIENT_PUBLIC_KEY" >> "$AUTH_KEYS" \
2121
&& chmod og-rw /root/.ssh "$AUTH_KEYS" \

Dockerfiles/test_suite-fedora

+2-2
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ ENV AUTH_KEYS=/root/.ssh/authorized_keys
66
ARG CLIENT_PUBLIC_KEY
77
ARG ADDITIONAL_PACKAGES
88

9-
# Insall Python so Ansible remediations can work
9+
# Install Python so Ansible remediations can work
1010
# Don't clean all, as the test scenario may require package install.
1111
RUN true \
1212
&& yum install -y openssh-clients openssh-server openscap-scanner \
@@ -15,7 +15,7 @@ RUN true \
1515
&& true
1616

1717
RUN true \
18-
&& for key_type in rsa ecdsa ed25519; do ssh-keygen -N '' -t $key_type -f /etc/ssh/ssh_host_${key_type}_key; done \
18+
&& for key_type in rsa ecdsa; do ssh-keygen -N '' -t $key_type -f /etc/ssh/ssh_host_${key_type}_key; done \
1919
&& mkdir -p /root/.ssh \
2020
&& printf "%s\n" "$CLIENT_PUBLIC_KEY" >> "$AUTH_KEYS" \
2121
&& chmod og-rw /root/.ssh "$AUTH_KEYS" \

Dockerfiles/test_suite-rhel

+2-2
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ ENV AUTH_KEYS=/root/.ssh/authorized_keys
66
ARG CLIENT_PUBLIC_KEY
77
ARG ADDITIONAL_PACKAGES
88

9-
# Insall Python so Ansible remediations can work
9+
# Install Python so Ansible remediations can work
1010
# Don't clean all, as the test scenario may require package install.
1111
RUN true \
1212
&& yum install -y openssh-clients openssh-server openscap-scanner \
@@ -15,7 +15,7 @@ RUN true \
1515
&& true
1616

1717
RUN true \
18-
&& for key_type in rsa ecdsa ed25519; do ssh-keygen -N '' -t $key_type -f /etc/ssh/ssh_host_${key_type}_key; done \
18+
&& for key_type in rsa ecdsa; do ssh-keygen -N '' -t $key_type -f /etc/ssh/ssh_host_${key_type}_key; done \
1919
&& mkdir -p /root/.ssh \
2020
&& printf "%s\n" "$CLIENT_PUBLIC_KEY" >> "$AUTH_KEYS" \
2121
&& chmod og-rw /root/.ssh "$AUTH_KEYS" \

0 commit comments

Comments
 (0)