Merge pull request #700 from redhatci/retries_timeout

Retry eject and increase timeout

Author: betoredhat

roles/vendors/dell/tasks/eject.yml

@@ -1,58 +1,47 @@
 ---
-- name: Eject
-  block:
-    - name: DELL Eject Virtual Media (if any)
-      community.general.redfish_command:
-        category: Manager
-        command: VirtualMediaEject
-        baseuri: "{{ bmc_address }}"
-        username: "{{ bmc_user }}"
-        password: "{{ bmc_password }}"
-        virtual_media:
-          image_url: "{{ boot_iso_url }}"
-        resource_id: iDRAC.Embedded.1
-  rescue:
-    - name: Get Virtual Media information
-      community.general.redfish_info:
-        category: Manager
-        command: GetVirtualMedia
-        baseuri: "{{ bmc_address }}"
-        username: "{{ bmc_user }}"
-        password: "{{ bmc_password }}"
-      register: result
+- name: Get Virtual Media information
+  community.general.redfish_info:
+    category: Manager
+    command: GetVirtualMedia
+    baseuri: "{{ bmc_address }}"
+    username: "{{ bmc_user }}"
+    password: "{{ bmc_password }}"
+    timeout: 120
+  retries: 3
+  register: result
+  delay: 10
+  until: result is succeeded
 
-    - name: Get blocking virtual_media
-      ansible.builtin.set_fact:
-        blocking_virtual_media: "{{ result.redfish_facts.virtual_media.entries
-            | flatten(levels=2)
-            | selectattr('ConnectedVia', 'defined') | list
-            | json_query('[?(
-                ConnectedVia == `URI`
-                && Image != null
-                && (
-                  contains(MediaTypes, `CD`)
-                  || contains(MediaTypes, `DVD`)
-                  || contains(MediaTypes, `VCD-DVD`)
-                )
-              )]'
-            ) | from_yaml
-          }}"
-
-    - name: Debug
-      ansible.builtin.debug:
-        var: blocking_virtual_media
-        verbosity: 1
-
-    - name: Attempting to eject blocking media
-      community.general.redfish_command:
-        category: Manager
-        command: VirtualMediaEject
-        baseuri: "{{ bmc_address }}"
-        username: "{{ bmc_user }}"
-        password: "{{ bmc_password }}"
-        virtual_media:
-          image_url: "{{ item.Image }}"
-        resource_id: iDRAC.Embedded.1
-      loop: "{{ blocking_virtual_media }}"
-      no_log: true
+- name: Attempting to eject blocking media (if any)
+  vars:
+    blocking_virtual_media: "{{ result.redfish_facts.virtual_media.entries
+        | flatten(levels=2)
+        | selectattr('ConnectedVia', 'defined') | list
+        | json_query('[?(
+            ConnectedVia == `URI`
+            && Image != null
+            && (
+              contains(MediaTypes, `CD`)
+              || contains(MediaTypes, `DVD`)
+              || contains(MediaTypes, `VCD-DVD`)
+            )
+          )]'
+        ) | from_yaml
+      }}"
+  community.general.redfish_command:
+    category: Manager
+    command: VirtualMediaEject
+    baseuri: "{{ bmc_address }}"
+    username: "{{ bmc_user }}"
+    password: "{{ bmc_password }}"
+    timeout: 120
+    virtual_media:
+      image_url: "{{ item.Image }}"
+    resource_id: iDRAC.Embedded.1
+  loop: "{{ blocking_virtual_media }}"
+  retries: 3
+  delay: 10
+  until: result is succeeded
+  register: result
+  no_log: true
 ...

roles/vendors/hpe/tasks/eject.yml

@@ -1,55 +1,48 @@
 ---
-- name: Eject
-  block:
-    - name: HPE Eject Virtual Media (if any)
-      community.general.redfish_command:
-        category: Manager
-        command: VirtualMediaEject
-        baseuri: "{{ bmc_address }}"
-        username: "{{ bmc_user }}"
-        password: "{{ bmc_password }}"
-        virtual_media:
-          image_url: "{{ boot_iso_url }}"
-        resource_id: 1
-  rescue:
-    - name: Get Virtual Media information
-      community.general.redfish_info:
-        category: Manager
-        command: GetVirtualMedia
-        baseuri: "{{ bmc_address }}"
-        username: "{{ bmc_user }}"
-        password: "{{ bmc_password }}"
-      register: result
+- name: Get Virtual Media information
+  community.general.redfish_info:
+    category: Manager
+    command: GetVirtualMedia
+    baseuri: "{{ bmc_address }}"
+    username: "{{ bmc_user }}"
+    password: "{{ bmc_password }}"
+    timeout: 120
+  register: result
+  retries: 3
+  delay: 10
+  until: result is succeeded
 
-    - name: Get blocking virtual_media
-      ansible.builtin.set_fact:
-        blocking_virtual_media: "{{ result.redfish_facts.virtual_media.entries
-            | flatten(levels=2)
-            | selectattr('ConnectedVia', 'defined') | list
-            | json_query('[?(
-                ConnectedVia == `URI`
-                && Image != null
-                && (
-                  contains(MediaTypes, `CD`)
-                  || contains(MediaTypes, `Floppy`)
-                  || contains(MediaTypes, `USBStick`)
-                  || contains(MediaTypes, `DVD`)
-                )
-              )]'
-            ) | from_yaml
-          }}"
-
-    - name: Attempting to eject blocking media
-      community.general.redfish_command:
-        category: Manager
-        command: VirtualMediaEject
-        baseuri: "{{ bmc_address }}"
-        username: "{{ bmc_user }}"
-        password: "{{ bmc_password }}"
-        timeout: 60
-        virtual_media:
-          image_url: "{{ item.Image }}"
-        resource_id: 1
-      loop: "{{ blocking_virtual_media }}"
-      no_log: true
+- name: Attempting to eject blocking media (if any)
+  vars:
+    blocking_virtual_media: "{{ result.redfish_facts.virtual_media.entries
+        | flatten(levels=2)
+        | selectattr('ConnectedVia', 'defined') | list
+        | json_query('[?(
+            ConnectedVia == `URI`
+            && Image != null
+            && (
+              contains(MediaTypes, `CD`)
+              || contains(MediaTypes, `Floppy`)
+              || contains(MediaTypes, `USBStick`)
+              || contains(MediaTypes, `DVD`)
+            )
+          )]'
+        ) | from_yaml
+      }}"
+  community.general.redfish_command:
+    category: Manager
+    command: VirtualMediaEject
+    baseuri: "{{ bmc_address }}"
+    username: "{{ bmc_user }}"
+    password: "{{ bmc_password }}"
+    timeout: 120
+    virtual_media:
+      image_url: "{{ item.Image }}"
+    resource_id: 1
+  loop: "{{ blocking_virtual_media }}"
+  retries: 3
+  delay: 10
+  until: result is succeeded
+  register: result
+  no_log: true
 ...