Skip to content

Commit 3713974

Browse files
authored
fix: temporarily disable lightspeed due to DPDY issues in next catalog index image (#3198)
* fix: temporarily disable lightspeed due to DPDY issues in 'next' catalog index image For context, the issue is due to the fact that the LS plugins are referenced using ghcr.io in the DPDY (fallback mechanism for example for plugins that do not build against the expected version of Backstage). This is supposed to be done after the rename of the LS plugins. At this point, we'll be able to re-enable them ref: RHIDP-15458 * fix: update integration tests for temporarily disabled lightspeed flavour Adjust test expectations now that lightspeed is disabled by default: - "replaces .npmrc": expect 1 init container instead of 2 - "creates rhdh with default Lightspeed flavour": skip until re-enabled ref: RHIDP-15458 Assisted-by: Claude
1 parent 35d8c0d commit 3713974

6 files changed

Lines changed: 13 additions & 10 deletions

File tree

‎bundle/backstage.io/manifests/backstage-operator.clusterserviceversion.yaml‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎bundle/rhdh/manifests/backstage-operator.clusterserviceversion.yaml‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎bundle/rhdh/manifests/rhdh-flavour-lightspeed-config_v1_configmap.yaml‎

Lines changed: 2 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
11
# Lightspeed (AI) flavour metadata
22
# This flavour is enabled by default and provides AI/Lightspeed functionality
3-
enabledByDefault: true
3+
# FIXME: temporarily disabled due to DPDY issues; to re-enable in https://redhat.atlassian.net/browse/RHIDP-15458
4+
enabledByDefault: false

‎dist/rhdh/install.yaml‎

Lines changed: 2 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎integration_tests/rhdh-config_test.go‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -276,11 +276,8 @@ var _ = When("create default rhdh", func() {
276276
deploy, err := backstageDeployment(ctx, k8sClient, ns, backstageName)
277277
g.Expect(err).To(Not(HaveOccurred()))
278278

279-
// no default flavour
280-
// g.Expect(len(deploy.PodSpec().InitContainers)).To(Equal(1))
281-
282-
// with default lightspeed flavour
283-
g.Expect(len(deploy.PodSpec().InitContainers)).To(Equal(2))
279+
// FIXME: restore to Equal(2) when lightspeed is re-enabled (RHIDP-15458)
280+
g.Expect(len(deploy.PodSpec().InitContainers)).To(Equal(1))
284281

285282
initCont := deploy.PodSpec().InitContainers[0]
286283
g.Expect(initCont.Name).To(Equal("install-dynamic-plugins"))
@@ -299,6 +296,9 @@ var _ = When("create default rhdh", func() {
299296

300297
It("creates rhdh with default Lightspeed flavour", func() {
301298

299+
// FIXME: re-enable when lightspeed is re-enabled (RHIDP-15458)
300+
Skip("Temporarily skipped: lightspeed disabled by default due to DPDY issues")
301+
302302
if !isProfile("rhdh") {
303303
Skip("Skipped for non rhdh config")
304304
}

0 commit comments

Comments
 (0)