Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alert on error #61

Open
cceckman opened this issue Aug 5, 2024 · 3 comments · Fixed by #95
Open

Alert on error #61

cceckman opened this issue Aug 5, 2024 · 3 comments · Fixed by #95
Labels
enhancement New feature or request

Comments

@cceckman
Copy link
Collaborator

cceckman commented Aug 5, 2024

(As noted in this issue: )

On significant / "should never happen" errors, it would be nice to alert the maintainers; e.g. "failed end-of-batch processing", or "couldn't send a message". Manually checking logs is not the best observability experience. :)

@cceckman cceckman added the enhancement New feature or request label Aug 5, 2024
@jdkaplan jdkaplan linked a pull request Sep 29, 2024 that will close this issue
@jdkaplan
Copy link
Collaborator

I'm used to doing log-based alerting based on severity level, which I think GCP supports, so I'm setting that up in #95.

The next step is to start sending errors to myself by clicking through all that config :)

@jdkaplan
Copy link
Collaborator

Wait, GitHub, too fast! We still have to configure the alerts!

@jdkaplan jdkaplan reopened this Sep 30, 2024
@jdkaplan
Copy link
Collaborator

jdkaplan commented Oct 6, 2024

I finally followed the guide for configuring a log-based alert, and now we have this alert policy for any log line with severity >= ERROR.

This should support multiple notification channels, so anyone with GCP access can add a new one and append it to the list for this alert.

The next step is to arrange for "things that shouldn't fail" to emit ERROR-level log messages. I'm preparing a PR that happens to arrange that for all the cron job handlers, so that should be solved soon 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants